Skip to content

fix in-app notification navigation#935

Merged
EmiD-10 merged 1 commit into
developfrom
910
Mar 18, 2026
Merged

fix in-app notification navigation#935
EmiD-10 merged 1 commit into
developfrom
910

Conversation

@Lainaaa
Copy link
Copy Markdown
Member

@Lainaaa Lainaaa commented Mar 16, 2026

Description

Issue was because initial Color.init(uiColor: .adamant.swipeBlockColor) did not provide tap to the responder instead was created InteractiveBackgroundView which use Color under the hood, however UIKit version instead of SwiftUI, which does not have the limitation.

Related issue

Closes #910

Testing

Just receive an in-app notification and make sure it tappable and provides you to the sender chat.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates PopupKit’s notification background to use a UIKit-backed view so it participates correctly in TransparentWindow hit testing, and exposes that helper view publicly from CommonKit for cross-module use.

Changes:

  • Replace Color(uiColor:) background in NotificationPresenterView with InteractiveBackgroundView.
  • Make InteractiveBackgroundView public with a public init and public UIViewRepresentable methods.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
PopupKit/Sources/PopupKit/Implementation/Views/NotificationPresenterView.swift Switches notification background to a UIKit-backed representable to support hit testing.
CommonKit/Sources/CommonKit/Helpers/UIHelpers/InteractiveBackgroundView.swift Promotes the helper view to a public API so it can be used by other modules (e.g., PopupKit).
Comments suppressed due to low confidence (1)

CommonKit/Sources/CommonKit/Helpers/UIHelpers/InteractiveBackgroundView.swift:28

  • updateUIView is empty, so if color changes (e.g., theme change, dynamic colors, state-driven updates), the existing UIView’s background won’t be updated. Update the uiView.backgroundColor (and any other relevant properties) in updateUIView to keep the representable in sync with SwiftUI updates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Adamant-im Adamant-im deleted a comment from Copilot AI Mar 18, 2026
@EmiD-10 EmiD-10 self-assigned this Mar 18, 2026
@EmiD-10 EmiD-10 marked this pull request as ready for review March 18, 2026 08:26
@EmiD-10 EmiD-10 merged commit ad2ffe4 into develop Mar 18, 2026
5 checks passed
@EmiD-10 EmiD-10 deleted the 910 branch March 18, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat, Enhancement] Improve in-chat scroll position | "New messages" separator

3 participants