Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates PopupKit’s notification background to use a UIKit-backed view so it participates correctly in TransparentWindow hit testing, and exposes that helper view publicly from CommonKit for cross-module use.
Changes:
- Replace
Color(uiColor:)background inNotificationPresenterViewwithInteractiveBackgroundView. - Make
InteractiveBackgroundViewpublicwith apublic initand publicUIViewRepresentablemethods.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| PopupKit/Sources/PopupKit/Implementation/Views/NotificationPresenterView.swift | Switches notification background to a UIKit-backed representable to support hit testing. |
| CommonKit/Sources/CommonKit/Helpers/UIHelpers/InteractiveBackgroundView.swift | Promotes the helper view to a public API so it can be used by other modules (e.g., PopupKit). |
Comments suppressed due to low confidence (1)
CommonKit/Sources/CommonKit/Helpers/UIHelpers/InteractiveBackgroundView.swift:28
updateUIViewis empty, so ifcolorchanges (e.g., theme change, dynamic colors, state-driven updates), the existingUIView’s background won’t be updated. Update theuiView.backgroundColor(and any other relevant properties) inupdateUIViewto keep the representable in sync with SwiftUI updates.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
EmiD-10
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue was because initial
Color.init(uiColor: .adamant.swipeBlockColor)did not provide tap to the responder instead was createdInteractiveBackgroundViewwhich useColorunder the hood, however UIKit version instead of SwiftUI, which does not have the limitation.Related issue
Closes #910
Testing
Just receive an in-app notification and make sure it tappable and provides you to the sender chat.