Chore/fx e2e test updates #2368
Conversation
* updated fixtures to use new POs * added POs for NewRFQ page and BlotterPage * moved some timeouts into utils
There was a problem hiding this comment.
rename to FxTilesPageObject
| readonly testInfo: TestInfo, | ||
| ) {} | ||
|
|
||
| async clickCurrency(currency: string) { |
There was a problem hiding this comment.
as credit,
| async clickCurrency(currency: string) { | |
| async selectFilter(filter: string) { |
There was a problem hiding this comment.
but should not be marked async - neither should the originals in the Credit POs - did we discuss this already?
| } | ||
|
|
||
| get spotTileNotionalInput() { | ||
| return this.page.locator("input[id='notional-input-EURUSD']") |
There was a problem hiding this comment.
this includes a specific currency pair
pass this in perhaps as a currencyPair param?
There was a problem hiding this comment.
as you have done below .. but please use currencyPair, no need to abbreviate to pair
| return this.page.locator("input[id='notional-input-EURUSD']") | ||
| } | ||
|
|
||
| async buyCurrencyPair(pair: string) { |
There was a problem hiding this comment.
no need for the CurrencyPair suffix here, we cannot buy anything else! 😄
There was a problem hiding this comment.
and having the parameter named as currencyPair seals the deal!
| return await this.page.getByTestId(`Sell-${pair}`).click() | ||
| } | ||
|
|
||
| get tradeId() { |
There was a problem hiding this comment.
I am leaning towards the pattern of having all the getters at the top .. happy to discuss this pattern, tho
packages/client/e2e/pages/index.ts
Outdated
| @@ -2,3 +2,6 @@ export * from "./CreditBlotterPageObject" | |||
| export * from "./CreditNewRfqPageObject" | |||
| export * from "./CreditRfqTilesPageObject" | |||
| export * from "./CreditSellSidePageObject" | |||
| // FX pages | |||
There was a problem hiding this comment.
no need for this comment .. the names say it all
packages/client/e2e/utils.ts
Outdated
| @@ -15,6 +15,11 @@ export enum TestTimeout { | |||
| EXTENDED = 90000, | |||
| } | |||
|
|
|||
| export enum RfqTimeout { | |||
There was a problem hiding this comment.
we have Credit, with RFQs .. this enum name is potentially confusing
also, no need to move these here .. they are not general timeouts .. I specifically moved/kept them in the spot tile spec so they are located in the relevant scope
|
|
||
| async clickCurrency(currency: string) { | ||
| return await this.page | ||
| .getByTestId("tab-bar-tabs") |
There was a problem hiding this comment.
this is where a Component would be useful, to tie in with reused UI elements - ref our conversation about the RTC-QA-BUG-VERSION branch
* renamed PO file * moved getters to top of PO file * cleaned up POs - removed async/awaits
No description provided.