Replace Gap and FlexBox with new spacing components #2369
Conversation
|
(auto-deploy) A deployment has been created for this Pull Request Preview linksAs part of the code review process, please ensure that you test against the following
PerformancePlease ensure that this PR does not degrade the performance of the UI. We should maintain a performance score of 95+. |
| @@ -76,11 +76,7 @@ export const NoRfqsWrapper = styled.div` | |||
|
|
|||
| // Card Footer | |||
There was a problem hiding this comment.
started off taking against this pointless-looking comment .. 😂
.. then found AcceptedCardState is not used, and the final item QuantityTypography is not part of the footer ..
I used to have a mode set in VS Code where it annotated the usage count of each identifier .. got annoying, but might be useful when refactoring, like this ..?
| > | ||
| <Typography>{EMAIL}</Typography> | ||
| {EMAIL} |
There was a problem hiding this comment.
minor point - what is the point of Link here .. I'd rather just have the plain Typography element inline - like this, it makes me think that Link has some "special powers" 🙂
| @@ -17,10 +16,10 @@ const Row = ({ | |||
| variant="Text sm/Regular underlined" | |||
| color="Component colors/Utility/Blue dark/utility-blue-dark-500" | |||
| onClick={onClick} | |||
| paddingBottom="md" | |||
There was a problem hiding this comment.
^ ^ can we get some typing on the color, do you think?
I know it has to allow "red", "white" and "inherit" and wotnot .. so not that easy .. but perhaps "csstype"'s Color | UISK theme Color ?
.. seems the base div component's def of color takes precedence - may not be worth the effort, but it would be nice to have completion, I would think ..
No description provided.