Restyle Tiles #2370
Restyle Tiles #2370
Conversation
SHolleworth
commented
Mar 27, 2025
SHolleworth
commented
packages/client/src/client/App/Credit/CreditRfqs/CreditRfqCards/styled.tsx
Outdated
Show resolved
Hide resolved
|
(auto-deploy) A deployment has been created for this Pull Request Preview linksAs part of the code review process, please ensure that you test against the following
PerformancePlease ensure that this PR does not degrade the performance of the UI. We should maintain a performance score of 95+. |
| case isTooLong: | ||
| return <WarningOverlay {...currencyPair} /> | ||
| } | ||
| })()} |
There was a problem hiding this comment.
I will understand if you dislike this pattern, but I got it from Victor Olivia if that gives it anymore credibility!
There was a problem hiding this comment.
you were right, I don't like it .. cunning, tho, I have to admit .. I can't claim a readability fail, as it is pretty clear what's going on, even if it takes you a few seconds to realise how 😄
There was a problem hiding this comment.
and, the alternative is not exactly pretty ..
| case isTooLong: | ||
| return <WarningOverlay {...currencyPair} /> | ||
| } | ||
| })()} |
There was a problem hiding this comment.
you were right, I don't like it .. cunning, tho, I have to admit .. I can't claim a readability fail, as it is pretty clear what's going on, even if it takes you a few seconds to realise how 😄
| case isTooLong: | ||
| return <WarningOverlay {...currencyPair} /> | ||
| } | ||
| })()} |
There was a problem hiding this comment.
and, the alternative is not exactly pretty ..
| color="Colors/Text/text-primary (900)" | ||
| role="alert" | ||
| > | ||
| {(() => { |
There was a problem hiding this comment.
different pattern here 😉
There was a problem hiding this comment.
which one do you dislike least?
There was a problem hiding this comment.
I think I prefer this .. although would it be better as a sub-component .. perhaps not as abstracting away could lead to less readable component overall
There was a problem hiding this comment.
gotta choose one, tho, I'd say .. so my vote is for this, your vote is equal, so we may need to draft in a 3rd party 😁
There was a problem hiding this comment.
I'll go for this one
...s/client/src/client/App/LiveRates/Tile/ExecutionResponse/overlays/components/OverlayBase.tsx
Show resolved
Hide resolved
