Update compiler to v3.1.3 and agtree to v3.2.4 #1118
Conversation
jellizaveta
requested review from
a team,
AdamWr,
maximtop,
scripthunter7 and
slvvko
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
There was a problem hiding this comment.
Other comments (2)
- .github/workflows/build-3p.yaml (33-33) This PR updates Node.js from 20.x to 22.x. Since Node.js 22.x is still relatively new, have you verified that all dependencies (especially the updated `@adguard/filters-compiler` v3.0.2 and other packages) are fully compatible with this version? If not, it might be worth testing thoroughly to ensure there are no compatibility issues.
-
.eslintignore (1-3)
The file is missing a newline at the end. It's a good practice to end text files with a newline character.
platforms/ scripts/build/ scripts/validation/
1 file skipped due to size limits:
- yarn.lock
💡 To request another review, post a new comment with "/windsurf-review".
jellizaveta
changed the title
| }, | ||
| "engines": { | ||
| "node": ">=18" | ||
| "node": ">=22" |
There was a problem hiding this comment.
which part of the code requires at least node 22?
There was a problem hiding this comment.
@adguard/[email protected] expected version ">=22"
There was a problem hiding this comment.
i think its too strict, probably we can reduce it in agtree as well
There was a problem hiding this comment.
I prefer not to decrease it in agtree,
especially when node.js v18 is no longer maintained now:
https://nodejs.org/en/about/previous-releases
let's keep it 22
slvvko
changed the title
|
NodeJS 24 will be entered into its active LTS period in 2025-10-28. |
we may keep 22 until it is maintained |
slvvko
changed the title
Update
@adguard/filters-compilertov3.1.3and@adguard/agtreetov3.2.4Dependencies' changes inside
@adguard/filters-compilerv3.1.3Fixes included
remove:true;rules to AdGuard syntax FiltersCompiler#236[$domain]cosmetic filters existing in a 3rd-party filters list are missing FiltersCompiler#258