Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #112

Open
wants to merge 290 commits into
base: feedback
Choose a base branch
from
Open

Feedback #112

wants to merge 290 commits into from

Conversation

aniWeyn
Copy link

@aniWeyn aniWeyn commented May 17, 2023

No description provided.

jorgennonstad and others added 30 commits May 5, 2023 14:19
deleted css file to replace it with scss
added some more elements as well as i made it rescalable
added some more images
i rewrote the website to scss and structured the css fles
i have photoshopped two images so they fit perfectly
i have added a lot of animations and intersection obervers for the scrolling
styled a lot of scenes and tried out some effekts
i added a lot of elements and functions using intersection observers
added a little detail
Merge pull request #23 from AdvancedCSS2023/man-css
jorgennonstad and others added 29 commits May 13, 2023 18:49
deleting comments animation_animations.scss
Copy link
Author

@aniWeyn aniWeyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! 👏 👏 👏

Comment on lines +114 to +116
.clouds__1>*, .clouds__2>*{
background-color: white;
}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello :) In this project probably this line worked, but I would not recommend this approach :)

Comment on lines +9 to +10
main {
& > div:nth-of-type(-n + 5) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants