-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don’t close or merge - Feedback #1
Open
github-classroom
wants to merge
148
commits into
feedback
Choose a base branch
from
main
base: feedback
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+8,429
−0
Open
Changes from 1 commit
Commits
Show all changes
148 commits
Select commit
Hold shift + click to select a range
f756516
Setting up GitHub Classroom Feedback
github-classroom[bot] 6ba3b62
The first commit: Making the skeleton of the page.
fd10c69
Add assignment deadline url
github-classroom[bot] 2b284fe
gsap notes
EmilSkolt da41630
Making the opening, scene 1 and the fundation of the page
EmilSkolt 0afb2c8
Merge pull request #2 from AdvancedCSS2023/Emil-Skolt
EmilSkolt dc6d2dc
Gsap Notes
EmilSkolt 2c09bf4
Merge pull request #3 from AdvancedCSS2023/Emil-Skolt
EmilSkolt b21829d
More progress. Fixed the pin scrolling for scene1
EmilSkolt ea06fa9
Merge pull request #4 from AdvancedCSS2023/Emil-Skolt
EmilSkolt 20ddac3
update
EmilSkolt 7fb7cc1
backup
EmilSkolt 63c4b4b
Merge pull request #6 from AdvancedCSS2023/Emil-Skolt
EmilSkolt d43c801
scene 2 and 4 html
Tobiasfjellvang 34aac62
Merge branch 'main' of https://github.com/AdvancedCSS2023/assignment-…
Tobiasfjellvang 8ea520e
added css for scene 2 and 4
Tobiasfjellvang f9a0ea1
html scene 3 and 5
PetterFuruli bdeca32
javascript scene 2 and 4
Tobiasfjellvang 92f4c64
scene 3 and 5 styling
PetterFuruli 2e3aeb5
images
PetterFuruli 8b5c339
Merge branch 'main' of https://github.com/AdvancedCSS2023/assignment-…
Tobiasfjellvang 6767b81
minor fixes
PetterFuruli 680e252
Merge branch 'main' of https://github.com/AdvancedCSS2023/assignment-…
Tobiasfjellvang 3b41105
scene 4 styling
Tobiasfjellvang ff23039
scene 2 styling
Tobiasfjellvang fde60e9
svg for scene 2 and 4
Tobiasfjellvang bed104c
namechange
Tobiasfjellvang 9ab12c5
latest update
EmilSkolt cd3f839
Merge branch 'main' into Emil-Skolt
EmilSkolt 965a325
Merge pull request #7 from AdvancedCSS2023/Emil-Skolt
EmilSkolt 77b612d
minor fixes
PetterFuruli c783f7c
Formatting
PetterFuruli ab0604a
ground fix
PetterFuruli be710f2
ground fix
PetterFuruli 47beef1
fix
PetterFuruli e0870cb
text
PetterFuruli 7d55c8b
del
PetterFuruli e02868a
css fixes
PetterFuruli 7587707
bug fix
PetterFuruli 5c9edc7
school changes
PetterFuruli 365ba53
animation fix
PetterFuruli 722abd0
test
PetterFuruli 383e80c
scene update
PetterFuruli cc75a23
scene 2 and 4
PetterFuruli aca3544
css
PetterFuruli 60e19bb
script change
PetterFuruli 4806680
bug fix
PetterFuruli f2643f5
reduced motion
PetterFuruli ea42a79
RM
PetterFuruli eeed454
bug fixes
Tobiasfjellvang b5d48fc
Merge branch 'main' of https://github.com/AdvancedCSS2023/assignment-…
Tobiasfjellvang c02c753
fixes
Tobiasfjellvang 8a8d776
added text
Tobiasfjellvang 890a5fa
rm
PetterFuruli caed8e4
rm
PetterFuruli ce3743c
Reduced motion fix
PetterFuruli f8081b9
fixed airplane
Tobiasfjellvang 57fc953
Merge branch 'main' of https://github.com/AdvancedCSS2023/assignment-…
Tobiasfjellvang 81444b1
fixes
Tobiasfjellvang 19f63c9
added text
Tobiasfjellvang 415de06
Reduced m
PetterFuruli 4c484e2
Final reduced motion
PetterFuruli 31463ef
kid kofi
PetterFuruli 6736fd1
fixes
Tobiasfjellvang 9d1c499
img update
PetterFuruli 452f602
test
PetterFuruli 69b53aa
arc fix
PetterFuruli badcc81
trying to fix scene1
Tobiasfjellvang 4b8304c
Merge branch 'main' of https://github.com/AdvancedCSS2023/assignment-…
Tobiasfjellvang d778663
media q
PetterFuruli a88421c
Merge pull request #8 from AdvancedCSS2023/Petter-test
PetterFuruli 430dc3d
fixed scene 1 position
Tobiasfjellvang 7b5bd2d
meida
PetterFuruli ba4e80d
fix
PetterFuruli f78a2fc
colors
PetterFuruli b9eeb5a
color update
PetterFuruli d0c5c2a
Merge pull request #9 from AdvancedCSS2023/Petter-test
PetterFuruli 01d14d4
more fixes
Tobiasfjellvang 7e7d38d
Merge branch 'main' of https://github.com/AdvancedCSS2023/assignment-…
Tobiasfjellvang a0b4398
test
EmilSkolt 59503b4
fixes
Tobiasfjellvang 219f971
Merge branch 'main' of https://github.com/AdvancedCSS2023/assignment-…
Tobiasfjellvang 465488c
color
PetterFuruli 2504ed5
fixed scene2
Tobiasfjellvang 2ad42c0
BEM scene2
Tobiasfjellvang 2ebd657
BEM scene4
Tobiasfjellvang 1306398
fixed the scroll bug
EmilSkolt f5714ec
fixing the sun position
EmilSkolt 323578e
changing headline
EmilSkolt 2038443
Adding UN pictures
EmilSkolt 113fda7
fixing the time lapse
EmilSkolt 87bd788
adding more UN pictures
EmilSkolt 8b8801b
Adjusting bird position + adding clouds
EmilSkolt c630c1d
Removing unnecessary plugins
EmilSkolt 1e7d730
Updating Scene 1
EmilSkolt 4585c85
latest Update
EmilSkolt 5c5350a
BEM
Tobiasfjellvang 5ac8013
fix
Tobiasfjellvang 21b2c87
sass variables
Tobiasfjellvang ea224bc
Changing the color gradient from JS to CSS
EmilSkolt 6062dfd
variables
Tobiasfjellvang f6a2eac
gradient change from java to css
EmilSkolt f7ef8dd
Merge branch 'main' of https://github.com/AdvancedCSS2023/assignment-…
EmilSkolt ddafda5
gradient variables
Tobiasfjellvang 4fd762d
darkmode
Tobiasfjellvang e618f12
color prefers
PetterFuruli c1295a1
sun moon
PetterFuruli 4c58639
day and night
PetterFuruli 5868384
sun and mon added
PetterFuruli 820f343
class
PetterFuruli 6afa3fc
changed id to classes
PetterFuruli b69df62
minor fixes
PetterFuruli 42481e5
Update README.md
Tobiasfjellvang 37df4d7
Update README.md
Tobiasfjellvang f3e908a
del
PetterFuruli 7fc8f0e
bem
PetterFuruli fda90e9
added variabels to css
Tobiasfjellvang 5392105
MQ
PetterFuruli 43d57ce
deleted some css
PetterFuruli c95bf92
fix
PetterFuruli 8fb3534
fixes
PetterFuruli 0e9dbf1
Update README.md
Tobiasfjellvang 1c2a05c
bug fix
PetterFuruli b969997
bug fix
PetterFuruli 52d10b1
changed/added color variables
Tobiasfjellvang d3a7c1e
Adding UN pictures and more scrollfunctions
EmilSkolt a8a34f8
Merge branch 'main' of https://github.com/AdvancedCSS2023/assignment-…
EmilSkolt dd47833
test
PetterFuruli 01ed5fa
text res
PetterFuruli edb28d3
text fix
PetterFuruli bdd1e19
Adding more color variables + dark mode
EmilSkolt 63d50be
Adding more dark mode features
EmilSkolt 5e23d8c
removing gsap notes
EmilSkolt ca66c71
Adding more text and cleaning up
EmilSkolt d481d72
styling the text
EmilSkolt 21eb9a2
dark mode variables
Tobiasfjellvang 8a7c742
Merge branch 'main' of https://github.com/AdvancedCSS2023/assignment-…
Tobiasfjellvang 3b9a68e
minor fix
PetterFuruli b0d7312
minor fixes
PetterFuruli 8c04a2d
adding containers for the text
EmilSkolt abdc017
text fix
PetterFuruli 59db193
small fixes
Tobiasfjellvang a0a4722
changing path test
EmilSkolt 3f7be60
back
EmilSkolt 1e38667
img update
PetterFuruli dbefa6a
sun fix
Tobiasfjellvang 262030a
changing to the right path
Tobiasfjellvang 4961241
fixing path
Tobiasfjellvang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
more fixes
commit 01d14d4b7ee5f197f9598fc1142b40e531a4110a
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lack of BEM 😢
duplicated ids 😢