Add adventure editing #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests for put requests in AdventureById currently fail.
The AdventureById view remains unchanged, so the put method tests currently fail.
When accessing the Adventure object directly, we have no QuerySet and so cannot call update(), instead we have to call save(). Storing the adventure ID means we can access the Adventure via filter(). This returns a QuerySet, so we can call update(). Calling update() instead of save() is more efficient and avoids a race condition wherein an object is changed in the database between retrieval and saving.
No attempt is made at authentication, nor at proper CSRF-handling. The assumption is made that authentication will be handled by a parent view.
Local repo was screwed up. This brings the local and remote repos to the same point.
Contributor
|
I yapf working correctly? Seems like the line length is not set correctly. Besides that I believe we're good to go unless someone has anything to say. |
Contributor
Author
|
Dang it. I took it out of the pre-commit hook because it was styling files I didn't want it to and I got annoyed by all the |
Contributor
Author
|
Turns out you're not meant to use hooks for that. Live and learn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #20. I expect this to need some work but I thought I'd get the ball rolling.
The commit history is a little bit wonky because I had a bit of a disaster locally and I'm too scared of losing my code again to try and make it look pretty. I hope that won't cause any issues.