Fix: Disputes Service URL

[gcatanese]

Fix #323

[gemini-code-assist]

Summary of Changes

Hello @gcatanese, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the Adyen Disputes service URL was being incorrectly generated due to a mismatch in the service name used in the URL path. The changes ensure that the service_url_base method constructs the correct URL for the Disputes service, aligning it with the expected Adyen API endpoint.

Highlights

• Disputes Service URL Correction: The logic for generating the Disputes service URL has been updated to use the correct singular service name, "DisputeService", instead of the previously expected "DisputesService".
• Service Name Mapping Refinement: An explicit mapping for 'Disputes' to 'DisputeService' and 'DataProtection' to 'DataProtectionService' was introduced, while removing a generic mapping that was causing the issue.
• Test Case Update: The corresponding unit test for the Disputes service URL generation was updated to reflect the corrected URL structure.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes the service URL for the Adyen Disputes service. The change updates the URL path component from DisputesService to DisputeService and adjusts the tests accordingly. Additionally, the logic for generating the DataProtection service URL has been refactored for better consistency. However, this refactoring introduces a breaking change for an associated test file which was not updated. My review includes a comment to address this issue.

[galesky-a]

Can we add a test for DataProtectionService ? or is there one already just not on this MR ?

Edit: Actually, looks like it is covered, got confused, can you just confirm then ?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[gcatanese]

DataProtectionService

@galesky-a I have added a test, good point.

Interesting finding: Data Protection API is not in the API Explorer