[Frontend / Feat] Improve evaluation runs page(s) / table(s) #2989
Conversation
Remove local SDK in oss gh
Updated image sources in README for cover and screenshots.
Update images in README.md
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on code formatting and consistency improvements across the SDK and documentation. The changes primarily condense multi-line code statements to single lines for better readability and updates documentation URLs to reflect a new domain structure.
Key Changes:
- Reformatted multi-line Pydantic model configurations to single lines
- Updated documentation URLs from
agenta.ai/docstodocs.agenta.ai - Adjusted Docker Compose configurations for production deployments
Reviewed Changes
Copilot reviewed 297 out of 748 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/agenta/client/backend/types/*.py | Condensed Pydantic model_config declarations from 3 lines to 1 line |
| sdk/agenta/client/backend/core/*.py | Reformatted function signatures and type casts to single lines |
| sdk/README.md | Updated documentation URLs to new domain structure |
| docs/** | Updated internal documentation links and removed deprecated configuration files |
| hosting/docker-compose/** | Modified service commands to use gunicorn instead of uvicorn directly |
| api/oss/tests/** | Reformatted multi-line assert statements and string concatenations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| extra="allow", | ||
| frozen=True, | ||
| json_schema_extra=lambda schema, model: None, # fmt: off | ||
| json_schema_extra=lambda schema, model: None, # Disable schema generation to prevent recursion |
There was a problem hiding this comment.
[nitpick] The comment has been improved to be more descriptive ('Disable schema generation to prevent recursion' vs 'fmt: off'), but it would be helpful to explain why disabling schema generation prevents recursion. Consider expanding the comment to explain the technical reason.
| json_schema_extra=lambda schema, model: None, # Disable schema generation to prevent recursion | |
| # Disable schema generation for this model to prevent infinite recursion during schema creation. | |
| # Pydantic's schema generation cannot handle recursive types (e.g., a model containing itself), | |
| # which can lead to stack overflows or errors. By disabling schema generation, we avoid these issues. | |
| json_schema_extra=lambda schema, model: None, |
| base_url: str, | ||
| timeout: typing.Optional[float] = None, | ||
| httpx_client: httpx.Client, | ||
| httpx_client: httpx.Client |
There was a problem hiding this comment.
[nitpick] The trailing comma has been removed from this parameter. While this doesn't affect functionality, it's inconsistent with Python best practices for function signatures where trailing commas help with cleaner diffs when parameters are added or removed. Consider keeping trailing commas on the last parameter.
|
|
||
| env_file: | ||
| - ${ENV_FILE:-./.env.oss.gh} | ||
| - ${ENV_FILE:-./.env.oss.dev} |
There was a problem hiding this comment.
The cron service is using .env.oss.dev while other services use .env.oss.gh. This inconsistency could lead to configuration mismatches in the production GitHub deployment. Should be .env.oss.gh to match the file pattern.
| - ${ENV_FILE:-./.env.oss.dev} | |
| - ${ENV_FILE:-./.env.oss.gh} |
|
|
||
| networks: | ||
| - agenta-oss-gh-network | ||
| - agenta-network |
There was a problem hiding this comment.
The cron service is using agenta-network while other services in this file use agenta-oss-gh-network. This network name mismatch will prevent the cron service from communicating with other services.
| - agenta-network | |
| - agenta-oss-gh-network |
|
|
||
| env_file: | ||
| - ${ENV_FILE:-./.env.oss.gh} | ||
| - ${ENV_FILE:-./.env.oss.dev} |
There was a problem hiding this comment.
The cron service is using .env.oss.dev instead of .env.oss.gh in the SSL configuration file. This should match the naming convention of the file (gh.ssl) and be consistent with other services.
| - ${ENV_FILE:-./.env.oss.dev} | |
| - ${ENV_FILE:-./.env.oss.gh} |
|
|
||
| networks: | ||
| - agenta-gh-ssl-network | ||
| - agenta-network |
There was a problem hiding this comment.
The cron service is using agenta-network while other services in this file use agenta-gh-ssl-network. This network name mismatch will prevent the cron service from communicating with other services in the SSL deployment.
| - agenta-network | |
| - agenta-gh-ssl-network |
| - "5672:5672" | ||
| - "15672:15672" |
There was a problem hiding this comment.
[nitpick] The RabbitMQ ports are now hardcoded instead of using environment variables (${RABBITMQ_PORT:-5672} and ${RABBITMQ_UI_PORT:-15672}). This reduces flexibility for deployments that need custom port mappings. Consider keeping the environment variable approach for consistency.
| - "5672:5672" | |
| - "15672:15672" | |
| - "${RABBITMQ_PORT:-5672}:5672" | |
| - "${RABBITMQ_UI_PORT:-15672}:15672" |
|
GitHub CI seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
tba...