Skip to content

feat: use browser://theme/ protocol for CSS imports in Agregore apps and tutorials #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: use browser://theme/ protocol for CSS imports in Agregore apps and tutorials #75

wants to merge 5 commits into from

Conversation

@akhileshthite
Copy link
Contributor

@RangerMauve
Copy link
Member

Should add info about the new --browser-theme-* once we've solidifed on that

@akhileshthite
Copy link
Contributor Author

Should add info about the new --browser-theme-* once we've solidifed on that

Addressed here: #74

@RangerMauve
Copy link
Member

I think the existing apps should have a fallback to the old agregore:// URL just in case folks are using an older version of the browser.

@akhileshthite
Copy link
Contributor Author

I think the existing apps should have a fallback to the old agregore:// URL just in case folks are using an older version of the browser.

Yep, we'll need to add the fallback to the protocol handler, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akhileshthite @RangerMauve