Migrate gcs sink integration #552
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Claudenw
changed the base branch from
main
to
FEAT_common_sink_integration_tests
# Conflicts: # commons/src/testFixtures/java/io/aiven/commons/kafka/testkit/KafkaConnectRunner.java
Claudenw
force-pushed
the
migrate_gcs_sink_integration
branch
from
1491b14 to
9295cc3
Compare
|
|
||
| private BlobContainerAsyncClient containerClient; | ||
| private BlobAsyncClient blobClient; | ||
|
|
Contributor
There was a problem hiding this comment.
can remove if you want :D
| @Override | ||
| public int compareTo(Record o) { | ||
| int result = value.toString().compareTo(o.value.toString()); | ||
| // String[] schema = value.getSchema().getFields().stream().map(Schema.Field::name).toArray(String[]::new); |
Contributor
There was a problem hiding this comment.
Theres a good bit of commented out code here, needs to be either added back in or deleted with reasoning.
| @Override | ||
| public void flush(final Map<TopicPartition, OffsetAndMetadata> currentOffsets) { | ||
| try { | ||
| LOG.debug("Flushing {} files", recordGrouper.records().size()); |
Contributor
There was a problem hiding this comment.
is it better to add the below for these two debug statements?
if(LOG.isdebugenabled()) {
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR establishes common sink integration testing framework and utilizes it to implement the existing sink integrations.
DO NOT MERGE
This phase of the PR is to establish that the implemented tests implement the tests found in the GCS code. In addition, it establishes the abstract testing framework that will be applied to Azure and S3 sink implementations to ensure that all implementations work the same.