Skip to content

Conversation

@Claudenw
Copy link
Contributor

@Claudenw Claudenw commented Nov 5, 2025

Closes #515

  • Added Scale class to present file sizes and memory sizes in human readable form.
  • fixed validators to show correct information.
  • Updated the S3SinkConfigDef so that it contains all the S3SinkConfiguration definition informtion.
  • Removed S3Sink configuration information out of S3SinkConfig

@Claudenw Claudenw requested a review from a team as a code owner November 5, 2025 13:46
@Claudenw Claudenw changed the base branch from main to feature/GH-514_Add_configuration_documentation November 19, 2025 08:50
@Claudenw Claudenw force-pushed the GH-515_add_S3_sink_documentation branch 2 times, most recently from e68069e to 47399af Compare November 21, 2025 13:12
@Claudenw Claudenw marked this pull request as draft November 21, 2025 16:11
# Conflicts:
#	commons/src/main/java/io/aiven/commons/collections/Scale.java
#	commons/src/main/java/io/aiven/kafka/connect/common/config/BackoffPolicyFragment.java
#	commons/src/main/java/io/aiven/kafka/connect/common/config/CommonConfig.java
#	commons/src/main/java/io/aiven/kafka/connect/common/config/FragmentDataAccess.java
#	commons/src/main/java/io/aiven/kafka/connect/common/config/OutputFormatFragment.java
#	commons/src/main/java/io/aiven/kafka/connect/common/config/SinkCommonConfig.java
#	commons/src/main/java/io/aiven/kafka/connect/common/config/SourceCommonConfig.java
#	commons/src/main/java/io/aiven/kafka/connect/common/config/validators/FilenameTemplateValidator.java
#	commons/src/main/java/io/aiven/kafka/connect/common/source/input/utils/FilePatternUtils.java
#	commons/src/test/java/io/aiven/kafka/connect/common/config/FileNameFragmentTest.java
#	commons/src/test/java/io/aiven/kafka/connect/common/config/validators/FilenameTemplateValidatorTest.java
#	commons/src/test/java/io/aiven/kafka/connect/common/source/input/ExampleSourceRecordIteratorTest.java
#	gcs-sink-connector/src/main/java/io/aiven/kafka/connect/gcs/GcsSinkConfig.java
#	s3-commons/src/main/java/io/aiven/kafka/connect/config/s3/S3ConfigFragment.java
 * Added Scale class to present file sizes and memory sizes in human readable form.
 * fixed validators to show correct information.
 * Updated the S3SinkConfigDef so that it contains all the S3SinkConfiguration definition informtion.
 * Removed S3Sink configuration information out of S3SinkConfig

# Conflicts:
#	commons/src/main/java/io/aiven/commons/collections/Scale.java
#	commons/src/main/java/io/aiven/kafka/connect/common/config/validators/ScaleValidator.java
#	s3-sink-connector/src/main/java/io/aiven/kafka/connect/s3/config/S3SinkConfig.java
#	s3-sink-connector/src/main/java/io/aiven/kafka/connect/s3/config/S3SinkConfigDef.java
@Claudenw Claudenw force-pushed the GH-515_add_S3_sink_documentation branch from 3669bfe to 21e9aac Compare November 25, 2025 10:08
@Claudenw Claudenw marked this pull request as ready for review November 25, 2025 10:12
Copy link
Contributor

@aindriu-aiven aindriu-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aindriu-aiven aindriu-aiven merged commit e55948d into Aiven-Open:feature/GH-514_Add_configuration_documentation Nov 25, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add configuration documentation for S3 Sink

2 participants