Missing declarations in color-picker module#122
Open
MuhammadQasim80 wants to merge 6 commits into
Open
Conversation
remove lib, jses update Readme
updated to @types bump to 1.4.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TextDirective, SliderDirective, DialogComponent were missing in color-picker.module
when you compile your application that is using angular4-color-picker with --prod flag then you get compile time errors. This is due to the fact that TextDirective, SliderDirective are DialogComponent are not added in declarations of color-picker.module.
I have added it in trunk. Please review it
color-picker.module.ts.zip