Skip to content

Add support for preference search SLurl#312

Merged
RyeMutt merged 1 commit into
AlchemyViewer:developfrom
gwigz:gwigz/preferences-search-slurl
Jun 13, 2026
Merged

Add support for preference search SLurl#312
RyeMutt merged 1 commit into
AlchemyViewer:developfrom
gwigz:gwigz/preferences-search-slurl

Conversation

@gwigz

@gwigz gwigz commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Parsing for preferences SLurl search query, and copy button. Clicking it with a search query will copy in i.e.

secondlife:///app/openfloater/preferences?search=lookat

SCR-20260613-sscq

@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: baea5b67-8d0c-4aac-a842-bfe88d4dc0be

📥 Commits

Reviewing files that changed from the base of the PR and between 03a5af0 and 9e735bb.

📒 Files selected for processing (4)
  • indra/newview/llfloaterpreference.cpp
  • indra/newview/llfloaterpreference.h
  • indra/newview/llviewerfloaterreg.cpp
  • indra/newview/skins/default/xui/en/floater_preferences.xml

📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Users can now copy the current preferences search filter as a shareable Second Life URL (SLURL) using a new copy button in the preferences search panel
    • Preferences dialog now properly initializes and preserves search filters when opened with pre-filled search parameters, allowing users to save and share their customized filtered preference views

Walkthrough

The PR adds a "copy search as SLURL" feature to the preferences floater, enabling users to share filtered preference searches via shareable Second Life URLs. It also enhances floater initialization to accept search parameters from URLs and propagates query parameters through the floater open handler.

Changes

Search SLURL Copy and Filter Initialization

Layer / File(s) Summary
Search copy implementation
indra/newview/llfloaterpreference.h, indra/newview/llfloaterpreference.cpp
Declares and implements onCopySearch() method with llclipboard.h and lluri.h includes. Generates a secondlife:///app/openfloater/preferences?search=... URL, escapes the filter text, and copies the SLURL to clipboard.
Callback registration and UI integration
indra/newview/llfloaterpreference.cpp, indra/newview/skins/default/xui/en/floater_preferences.xml
Registers the Pref.CopySearchAsSLURL commit callback in the constructor and adds the copy-search button to the preferences UI with tooltip and icon states. Adjusts search field layout (right offset to -28) to accommodate the new button.
URL parameter propagation and initialization
indra/newview/llviewerfloaterreg.cpp, indra/newview/llfloaterpreference.cpp
Updates LLFloaterOpenHandler::handle() to seed the key LLSD with query_map contents, enabling search parameters to pass through floater open handlers. Updates onOpen() to initialize mFilterEdit from key["search"] and trigger filter refresh when present.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A SLURL to copy with a click,
Search filters now stick and flip quick,
Parameters flow through the URL stream,
Preferences preserved—a reviewer's dream! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The PR description lacks key required sections including clear motivation, related issues link, testing verification, and completion of the provided checklist. Complete the full PR template with Related Issues link, checklist confirmations, testing details, and style/documentation verification before merging.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add support for preference search SLurl' clearly and concisely describes the main feature being added—SLURL support for preference searches.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@RyeMutt RyeMutt merged commit c222f5a into AlchemyViewer:develop Jun 13, 2026
13 checks passed
@gwigz gwigz deleted the gwigz/preferences-search-slurl branch June 14, 2026 09:40
@RyeMutt RyeMutt added this to the NEXT milestone Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants