fix: generate correct top_k columns when no shared expert#3
Open
Mikezhang001 wants to merge 1 commit into
Open
fix: generate correct top_k columns when no shared expert#3Mikezhang001 wants to merge 1 commit into
Mikezhang001 wants to merge 1 commit into
Conversation
Author
|
HI @SzymonOzog, I noticed a bug in jit_moe.py when using --no-shared-expert. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
When running
jit_moe.pywith--no-shared-expert,topk_idsisgenerated with
top_k-1columns instead of the expectedtop_kcolumns.This happens because
generate_topk_idsis always called withtop_k-1,but the
if args.shared_expertblock that appends the missing column isskipped when there is no shared expert.
Fix
Move the
generate_topk_idscall inside theif/elseblock:top_k-1routed experts, then append1 fixed shared expert (index
E-1) → totaltop_kcolumnstop_kexperts from allEexperts → total
top_kcolumns