feat: add metrics tracking http request#10
Merged
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull request overview
Adds OpenTelemetry metrics instrumentation to track counts and durations of outbound model (LLM) calls and MCP tool calls, improving observability of the responses server’s external dependencies.
Changes:
- Introduce a shared metrics module (
src/lib/metrics.ts) defining counters and histograms for model calls and MCP tool calls. - Record model call duration/count (tagged with status code + model name) in
handleOneTurnStream. - Record MCP tool call duration/count (tagged with status code + tool/server identifiers) in
callMcpTool, and extend the OTEL mock in tests to support metrics.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/routes/responses/handleOneTurn.ts |
Records model-call counter + duration around streamed LLM calls. |
src/routes/responses/handleOneTurn.test.ts |
Extends OpenTelemetry mock to include metrics.getMeter() and instruments. |
src/mcp.ts |
Records MCP tool-call counter + duration around MCP calls. |
src/lib/metrics.ts |
Defines OpenTelemetry meter instruments for model/MCP metrics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
frac
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.