forked from couds/react-bulma-components
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update #1
Merged
Merged
Update #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add renderAs=h2 to Heading storybook * heading: Use double quotes rather than single
Allows creating Intedeterminate progress bars
* Add 'checked' property to the checkbox Currently, the `checked` property is not applied. * Pass checkbox 'checked' property in spread
* fix doc typo * made dropdown disabled prop optional
* Add Icon.Text and ts definition * Add Icon.Text documentation and example * Fix tests * Add deprecation warning to text prop to Icon component * Do not add icon prop when text props (deprecated) * fix snapshot
Fixed docs typos. Modal.Card.Head doesn't exist.
* fix doc typo * made dropdown disabled prop optional * added full width prop to Select component * correct copy paste error
Replace message description with navbar description.
* Add menuId prop to allow passing of ID to dropdown menu * Revert package-lock.json
The domRef definition that was there would have a nonsensical type like React.RefObject<"input"> when it should be referring to the actual element like React.RefObject<HTMLInputElement> based on TComponent. This would necessitate doing ugly casts like ``` ref as unknown as HTMLInputElement ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.