feat(mpd): add playing-interval option - #4334
Merged
Merged
Conversation
Owner
|
Could you add this new option to the man 🙏 |
Contributor
Author
|
@Alexays done! |
Contributor
Author
|
Hey @Alexays, is there anything else blocking this from being merged? I'd love to continue using the official package instead of my fork 🙂 Let me know if you need me to squash the commits or do anything else. |
# Conflicts: # include/modules/mpd/state.inl.hpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #4325, the default 1-second timer for the
Playingstate is very noticeable when running MPD server onlocalhost. This pull request adds aplaying-intervaloption to thempdmodule which allows configuring this interval (in milliseconds). Defaults to 1000 milliseconds.Closes #4325.