fix(tray): fall back when dbus menu is unavailable - #5238
Open
nanomatters wants to merge 1 commit into
Open
Conversation
Some SNI items advertise a menu object path without exporting the com.canonical.dbusmenu interface. Creating a GTK dbus menu for those items prevents their native context menu from being used. Probe the mandatory dbusmenu "Version" property and only create the GTK menu after the probe succeeds. Until then, keep the existing ContextMenu fallback so startup remains non-blocking and ordinary tray actions are unchanged.
nanomatters
force-pushed
the
fix/sni-native-context-menu
branch
from
August 13, 2026 11:04
e47bfb0 to
f3b0665
Compare
Author
|
The clang-format is failing but it is not a file I modified. ./src/modules/backlight.cpp:127:55: error: code should be clang-formatted [-Wclang-format-violations] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some SNI items advertise a menu object path without exporting the com.canonical.dbusmenu interface. Creating a GTK dbus menu for those items prevents their native context menu from being used.
Probe the mandatory dbusmenu "Version" property and only create the GTK menu after the probe succeeds. Until then, keep the existing ContextMenu fallback so startup remains non-blocking and ordinary tray actions are unchanged.
This example below is when running Windows native Steam which renders its own menu.
Related issues
Checklist
clang-formatninja -C build)man/)