Conversation
…etector3 Fix geometry error and json
pkurash
requested review from
a team,
benedikt-voelkel,
mconcas,
sawenzel and
shahor02
as code owners
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
Collaborator
Looks reasonably good to me, I will find the time to test it locally. Thanks! |
shahor02
requested changes
Sep 4, 2024
DataFormats/Detectors/Common/include/DetectorsCommonDataFormats/DetID.h
Outdated
Show resolved
Hide resolved
Collaborator
njacazio
reviewed
Oct 8, 2025
Contributor
Author
|
Hello Nicolo,
I was going to switch to the three letter notation, just kept it for the sake of my simulation which used two-letter detector name and namespaces. I also like your idea of the name, will try to make the change as soon as possible
Regards,
Podist
On Wed, 2025-10-08 at 07:49 -0700, Nicolò Jacazio wrote:
@njacazio commented on this pull request.
________________________________
In Common/SimConfig/src/SimConfig.cxx<#13476 (comment)>:
@@ -98,7 +98,8 @@ void SimConfig::determineActiveModules(std::vector<std::string> const& inputargs
activeModules[i] != "TF3" &&
activeModules[i] != "RCH" &&
activeModules[i] != "MI3" &&
- activeModules[i] != "ECL") {
+ activeModules[i] != "ECL" &&
+ activeModules[i] != "FD") {
Hi @pkurash<https://github.com/pkurash> we should stick to the 3 letter nomenclature, how about FD3?
—
Reply to this email directly, view it on GitHub<#13476 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AETLCRCVZTKRBPRHATHANBL3WUP7NAVCNFSM6AAAAABNTVHVBGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGMJVGIYDMMRQGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Collaborator
|
Ciao @pkurash I think we can merge this if you're ready |
Contributor
Author
Hello, yes, I think it is ready to be merged. |
njacazio
previously approved these changes
Oct 13, 2025
Collaborator
|
Ciao @shahor02 could you please re-review the PR? Many thanks! |
auto-merge was automatically disabled
October 16, 2025 20:37
Head branch was pushed to by a user without write access
mconcas
approved these changes
Oct 20, 2025
Collaborator
|
Error while checking build/O2/fullCI_slc9 for d893b69 at 2025-10-20 12:48: Full log here. |
Collaborator
Collaborator
|
Thanks! |
plariono
pushed a commit
to plariono/AliceO2
that referenced
this pull request
Oct 23, 2025
* basic geometry and data format for new detector * fixed geometry and json * fixed hits * updated geometry and detector source code * updated geometry and detector source code * minor fixes * sensitive volumes * geometry update * geometry update * enable hits * enable hits * enable hits * fix channel ids * More flexible confgurable parameters * More flexible confgurable parameters * update parameters and geometry * fixed ring sizes * merge conflict * GPU * fix conflicts * resolve conflicts * head * GPU * added Constants.h to store constants * Adding Constants.h and correcting formatting issues * Adding Constants.h and correcting formatting issues * Adding Constants.h and correcting formatting issues * Adding Constants.h and correcting formatting issues * Adding Constants.h and correcting formatting issues * Adding Constants.h and correcting formatting issues * created new namespace * created new namespace * created new namespace * change name of the detector * change name of the detector * check errors * check errors * Flexible ring radii, a new Boolean switch for module A, module coverage in eta independent of their position * correct default number of ring of A side * Modified default parameters * Hits from charged tracks only * Fixed hit merging * return to the previous choice * updated eta min/max definitions * updated eta definitions * remove spurious files * Update CMake * removed GPU file * Add FD detector * including aluminium containers * including aluminium containers * including aluminium containers * including aluminium containers * including aluminium containers * Please consider the following formatting changes * Updated Readme * introduced FD hit data format * introduced FD hit data format * corrected copyright notice * corrected copyright notice * corrected copyright notice * Finding detId from fMC * colors * change detector name * change detector name * change detector name * change detector name * Fix formatting in CMakeLists.txt for FD3Simulation --------- Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Software model for future FV0 like detector consisting of two segmented scintillator disks.