Skip to content

tpcdigits.root readout#14604

Closed
ChSonnabend wants to merge 4 commits intoAliceO2Group:devfrom
ChSonnabend:tpcdigtis_readout
Closed

tpcdigits.root readout#14604
ChSonnabend wants to merge 4 commits intoAliceO2Group:devfrom
ChSonnabend:tpcdigtis_readout

Conversation

@ChSonnabend
Copy link
Collaborator

@ChSonnabend ChSonnabend commented Aug 20, 2025

What do you think @sawenzel and @davidrohr ?
This way the digits are streamed out, but the reco (with --input-type digits) until track-level doesn't yet work without --disable-mc.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 20, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild alibuild mentioned this pull request Aug 20, 2025
Merged
ChSonnabend added a commit to ChSonnabend/AliceO2 that referenced this pull request Aug 20, 2025
@ChSonnabend
Merge pull request #33 from alibuild/alibot-cleanup-14604
961be14 
Please consider the following formatting changes to AliceO2Group#14604
sawenzel
sawenzel reviewed Aug 20, 2025
View reviewed changes
Detectors/TPC/workflow/src/ChunkedDigitPublisher.cxx
#include "DetectorsRaw/HBFUtilsInitializer.h"
#include "TPCSimulation/CommonMode.h"
#include "DetectorsBase/Detector.h"
#include "DPLUtils/MakeRootTreeWriterSpec.h"
Copy link
Collaborator

@sawenzel sawenzel Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the normal TPC digitizer workflow, we employ a specialized header TPCDigitRootWriterSpec.h which defines a Writer class for TPC digits. I would try to utilize this. Likely it offers correct treatment for the MC truth classes.

@ChSonnabend ChSonnabend marked this pull request as draft August 20, 2025 13:17
@alibuild alibuild mentioned this pull request Aug 20, 2025
Closed
@sawenzel
Copy link
Collaborator

sawenzel commented Aug 21, 2025

Closing in favour of #14608.

@sawenzel sawenzel closed this Aug 21, 2025
@ChSonnabend ChSonnabend deleted the tpcdigtis_readout branch August 21, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sawenzel sawenzel sawenzel left review comments

@davidrohr davidrohr Awaiting requested review from davidrohr davidrohr is a code owner

@wiechula wiechula Awaiting requested review from wiechula wiechula is a code owner

@shahor02 shahor02 Awaiting requested review from shahor02 shahor02 is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ChSonnabend @sawenzel