ITS: skip processing entirely if no clusters/rofs in TF#14629
ITS: skip processing entirely if no clusters/rofs in TF#14629mconcas merged 1 commit intoAliceO2Group:devfrom
Conversation
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
In every run the first few 100 TFs have ITS empty: the data are discarded during the ROF rate ramp-up. |
|
What do you mean with discarded since Catalin used this data for an async-like pass, I assume we still fully process this data? |
We do but with empty ITS the AOD contains no vertices. This affects 1st couple of seconds of every run. |
|
ah ok of course, I misunderstood your comment, thanks! |
|
It seems to me that this protection does not hurt, even though from Ruben's comment it may not be necessary. Nevertheless, Felix checked that it fixes locally the crash on GPU reported in https://its.cern.ch/jira/browse/O2-6264. So. I would be in favour of merging it and run a new test |
…#14629) Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Should fix the error reported in https://its.cern.ch/jira/browse/O2-6264 for test 1.
The issue seems to be that sometimes there are TFs which do not contain any digits/rof information for ITS.
The cpu code handles this correctly the gpu code does not since it tries to then to pin empty buffers.
This fixes this by entirely skipping any processing if there are no clusters/rofs received.
I tested that downstream devices that use ITS track info handle this situation by running the pvertexer just on ITS (is this enough as a test?).