Skip to content

Conversation

@fgrosa
Copy link
Collaborator

@fgrosa fgrosa commented Jan 18, 2026

This PR fixes the vertexing for Xic and OmegaC baryons, by removing the call to propagateTracksToVertex. As observed also for the HF triggers (see 3ea6038) propagateTracksToVertex fails silently for a large fraction of the cases, leading to huge efficiency losses. It is instead better to set propagateToPCA to true in the DCAFitter configuration.
Tagging @zhangbiao-phy @stefanopolitano @xinyepeng @gluparel for info (might be useful to reproduce derived datasets, especially if produced recently).

@github-actions
Copy link

O2 linter results: ❌ 0 errors, ⚠️ 7 warnings, 🔕 7 disabled

@github-actions github-actions bot changed the title Fix vertexing for charm baryons to cascade + bachelors [PWGHF] Fix vertexing for charm baryons to cascade + bachelors Jan 18, 2026
@fgrosa fgrosa enabled auto-merge (squash) January 18, 2026 17:44
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @fgrosa.

@fgrosa fgrosa merged commit 9d8d424 into AliceO2Group:master Jan 18, 2026
13 checks passed
@vkucera
Copy link
Collaborator

vkucera commented Jan 19, 2026

@fgrosa Does this affect also the V0 + bachelor tracking in HfTrackIndexSkimCreatorCascades?

@vkucera
Copy link
Collaborator

vkucera commented Jan 19, 2026

Tagging @JaeYoonCHO

@fgrosa
Copy link
Collaborator Author

fgrosa commented Jan 19, 2026

Hi @vkucera I did not notice that it was used also there. Anyway if no cut is applied after that call, it might be ok, but I did not test it (the most problematic case was the Xic+, that I extensively tested before pushing the fix, since we were not understanding why we were recovering only ~1/10 of the triggered Xic+). If a pt cut is applied afterwards (

// cascade candidate pT cut
const auto ptCascCand = RecoDecay::pt(pVecBach, pVecV0);
if (ptCascCand < config.ptCascCandMin) {
continue;
}
) it might also have an impact (what I noticed is that after the propagateTracksToVertex the momenta of the tracks are completely screwed), but I think that usually we don't apply a min pT cut for the pK0S. I will anyway open a new PR to remove it there as well.

@vkucera
Copy link
Collaborator

vkucera commented Jan 19, 2026

Hi @vkucera I did not notice that it was used also there. Anyway if no cut is applied after that call, it might be ok, but I did not test it (the most problematic case was the Xic+, that I extensively tested before pushing the fix, since we were not understanding why we were recovering only ~1/10 of the triggered Xic+). If a pt cut is applied afterwards (

// cascade candidate pT cut
const auto ptCascCand = RecoDecay::pt(pVecBach, pVecV0);
if (ptCascCand < config.ptCascCandMin) {
continue;
}

) it might also have an impact (what I noticed is that after the propagateTracksToVertex the momenta of the tracks are completely screwed), but I think that usually we don't apply a min pT cut for the pK0S. I will anyway open a new PR to remove it there as well.

OK, thanks!

@mfaggin
Copy link
Collaborator

mfaggin commented Jan 19, 2026

Ciao @fgrosa , I see that the solution in this PR consists in:

  1. put propagateToPCA to true for the DCAFitter object
  2. remove the call of propagateTracksToVertex

In other PWGHF tasks I see that this propagateTracksToVertex function is still used, for example (but there are many others):

According to your understanding, are the two cases equivalent? Or does one have to switch everywhere to the solution "propagateToPCA == true + remove propagateTracksToVertex calls" ? In the mentioned cases the daughter momenta are always used to calculate invariant mass values on which some selections are applied later.

Thanks in advance, it's just for my understanding, and to understand if analysers have to be pinged.

@vkucera
Copy link
Collaborator

vkucera commented Jan 19, 2026

Good point @mfaggin !
Would be good to include any further propagation of this change as part of #14541.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

4 participants