[PWGLF] Add event selection flag to the he3hadmult table - #17319
Open
GiorgioAlbertoLucia wants to merge 3 commits into
Open
[PWGLF] Add event selection flag to the he3hadmult table#17319GiorgioAlbertoLucia wants to merge 3 commits into
GiorgioAlbertoLucia wants to merge 3 commits into
Conversation
|
O2 linter results: ❌ 22 errors, |
GiorgioAlbertoLucia
marked this pull request as ready for review
August 5, 2026 07:03
GiorgioAlbertoLucia
requested review from
HorstMa,
abmodak,
alibuild,
dmallick2,
ercolessi,
gbencedi,
lhusova,
maciacco,
mario-krueger,
mpuccio,
omvazque,
prottayCMT,
romainschotter,
skundu692 and
smaff92
as code owners
August 5, 2026 07:03
maciacco
approved these changes
Aug 5, 2026
maciacco
enabled auto-merge (squash)
August 5, 2026 07:05
Collaborator
Collaborator
|
Error while checking build/O2Physics/code-check for 036f374 at 2026-08-05 22:21: Full log here. |
Collaborator
vkucera
disabled auto-merge
August 5, 2026 08:25
vkucera
requested changes
Aug 5, 2026
Collaborator
There was a problem hiding this comment.
@GiorgioAlbertoLucia Please fix the PR title.
It's is wrong and very confusing. It's a statement and it's not clear whether it's the reason of the PR or its outcome. Plus "now'" is meaningless in this context. It doesn't convey any information about the scope of the changes either. Please read the references in the contribution guidelines and learn to formulate a proper commit message.
GiorgioAlbertoLucia
changed the title
Contributor
Author
@vkucera the PR title has been fixed. I removed the "now" and it is now not a statement, but the content is the same. The only goal of the pr is to store event selection flags in the output table, specifically, in the multiplicity table. If you are still not convinced, please feel free to leave a suggestion |
Collaborator
|
Thanks @GiorgioAlbertoLucia , but the title is still wrong and still does not follow the guidelines. The multiplicity table is produced by |
GiorgioAlbertoLucia
changed the title
Contributor
Author
@vkucera I understand the confusion. The title referred to the multiplicity table pertinent to the analysis task. The initial comment was unclear about what the issue was. Hopefully, now the title is clearer. |
vkucera
changed the title
Collaborator
Thanks. Please use the imperative mood in your future PRs (as instructed in the guidelines). |
vkucera
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.