Skip to content

Noundef intrinsic arguments #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nunoplopes merged 3 commits into from
Jan 16, 2026
Merged

Noundef intrinsic arguments #1276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60fe437
initial commit
regehr Jan 15, 2026
49bc70d
pass reference instead of object
regehr Jan 16, 2026
48538ff
Remove addNoundefAssumes call from llvm2alive
nunoplopes Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 32 additions & 2 deletions llvm_util/llvm2alive.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,16 @@ class llvm2alive_ : public llvm::InstVisitor<llvm2alive_, unique_ptr<Instr>> {
return make_unique<Assume>(*make_intconst(0, 1), Assume::AndNonPoison);
}

void addNoundefAssumes(const llvm::CallBase &i,
const std::initializer_list<Value *> &args) {
unsigned idx = 0;
for (auto *arg : args) {
if (i.paramHasAttr(idx, llvm::Attribute::NoUndef))
BB->addInstr(make_unique<Assume>(*arg, Assume::WellDefined));
++idx;
}
}

public:
llvm2alive_(llvm::Function &f, const llvm::TargetLibraryInfo &TLI, bool IsSrc,
const vector<GlobalVariable*> &gvsInSrc)
Expand Down Expand Up @@ -831,6 +841,7 @@ class llvm2alive_ : public llvm::InstVisitor<llvm2alive_, unique_ptr<Instr>> {
case llvm::Intrinsic::ucmp:
case llvm::Intrinsic::scmp: {
PARSE_BINOP();
addNoundefAssumes(i, {a, b});
BinOp::Op op;
switch (i.getIntrinsicID()) {
case llvm::Intrinsic::sadd_with_overflow: op=BinOp::SAdd_Overflow; break;
Expand Down Expand Up @@ -867,6 +878,7 @@ class llvm2alive_ : public llvm::InstVisitor<llvm2alive_, unique_ptr<Instr>> {
case llvm::Intrinsic::expect_with_probability:
case llvm::Intrinsic::is_constant: {
PARSE_UNOP();
addNoundefAssumes(i, {val});
UnaryOp::Op op;
switch (i.getIntrinsicID()) {
case llvm::Intrinsic::bitreverse: op = UnaryOp::BitReverse; break;
Expand All @@ -892,6 +904,7 @@ class llvm2alive_ : public llvm::InstVisitor<llvm2alive_, unique_ptr<Instr>> {
case llvm::Intrinsic::vector_reduce_umax:
case llvm::Intrinsic::vector_reduce_umin: {
PARSE_UNOP();
addNoundefAssumes(i, {val});
UnaryReductionOp::Op op;
switch (i.getIntrinsicID()) {
case llvm::Intrinsic::vector_reduce_add: op = UnaryReductionOp::Add; break;
Expand All @@ -912,8 +925,9 @@ class llvm2alive_ : public llvm::InstVisitor<llvm2alive_, unique_ptr<Instr>> {
case llvm::Intrinsic::vector_reduce_fmax:
case llvm::Intrinsic::vector_reduce_fminimum:
case llvm::Intrinsic::vector_reduce_fmaximum: {
PARSE_UNOP();
FpUnaryReductionOp::Op op;
PARSE_UNOP();
addNoundefAssumes(i, {val});
FpUnaryReductionOp::Op op;
switch (i.getIntrinsicID()) {
case llvm::Intrinsic::vector_reduce_fmin: op = FpUnaryReductionOp::FMin; break;
case llvm::Intrinsic::vector_reduce_fmax: op = FpUnaryReductionOp::FMax; break;
Expand All @@ -935,6 +949,7 @@ class llvm2alive_ : public llvm::InstVisitor<llvm2alive_, unique_ptr<Instr>> {
case llvm::Intrinsic::objectsize:
{
PARSE_TRIOP();
addNoundefAssumes(i, {a, b, c});
TernaryOp::Op op;
switch (i.getIntrinsicID()) {
case llvm::Intrinsic::fshl: op = TernaryOp::FShl; break;
Expand All @@ -955,6 +970,7 @@ class llvm2alive_ : public llvm::InstVisitor<llvm2alive_, unique_ptr<Instr>> {
case llvm::Intrinsic::experimental_constrained_fmuladd:
{
PARSE_TRIOP();
addNoundefAssumes(i, {a, b, c});
FpTernaryOp::Op op;
switch (i.getIntrinsicID()) {
case llvm::Intrinsic::fma:
Expand Down Expand Up @@ -985,6 +1001,7 @@ class llvm2alive_ : public llvm::InstVisitor<llvm2alive_, unique_ptr<Instr>> {
case llvm::Intrinsic::experimental_constrained_maximum:
{
PARSE_BINOP();
addNoundefAssumes(i, {a, b});
FpBinOp::Op op;
switch (i.getIntrinsicID()) {
case llvm::Intrinsic::copysign: op = FpBinOp::CopySign; break;
Expand Down Expand Up @@ -1028,6 +1045,7 @@ class llvm2alive_ : public llvm::InstVisitor<llvm2alive_, unique_ptr<Instr>> {
case llvm::Intrinsic::experimental_constrained_trunc:
{
PARSE_UNOP();
addNoundefAssumes(i, {val});
FpUnaryOp::Op op;
switch (i.getIntrinsicID()) {
case llvm::Intrinsic::canonicalize: op = FpUnaryOp::Canonicalize; break;
Expand Down Expand Up @@ -1057,6 +1075,7 @@ class llvm2alive_ : public llvm::InstVisitor<llvm2alive_, unique_ptr<Instr>> {
case llvm::Intrinsic::frexp:
{
PARSE_UNOP();
addNoundefAssumes(i, {val});
FpUnaryOpVerticalZip::Op op;
switch (i.getIntrinsicID()) {
case llvm::Intrinsic::frexp: op = FpUnaryOpVerticalZip::FrExp; break;
Expand Down Expand Up @@ -1084,6 +1103,7 @@ class llvm2alive_ : public llvm::InstVisitor<llvm2alive_, unique_ptr<Instr>> {
case llvm::Intrinsic::fptosi_sat:
{
PARSE_UNOP();
addNoundefAssumes(i, {val});
FpConversionOp::Op op;
switch (i.getIntrinsicID()) {
case llvm::Intrinsic::experimental_constrained_sitofp: op = FpConversionOp::SIntToFP; break;
Expand Down Expand Up @@ -1114,6 +1134,7 @@ class llvm2alive_ : public llvm::InstVisitor<llvm2alive_, unique_ptr<Instr>> {
case llvm::Intrinsic::experimental_constrained_fcmps:
{
PARSE_BINOP();
addNoundefAssumes(i, {a, b});
auto *fcmp = cast<llvm::ConstrainedFPCmpIntrinsic>(&i);
auto cond = parse_fcmp_cond(fcmp->getPredicate());
ret = make_unique<FCmp>(*ty, value_name(i), cond, *a, *b, FastMathFlags(),
Expand All @@ -1123,6 +1144,7 @@ class llvm2alive_ : public llvm::InstVisitor<llvm2alive_, unique_ptr<Instr>> {
case llvm::Intrinsic::is_fpclass:
{
PARSE_BINOP();
addNoundefAssumes(i, {a, b});
TestOp::Op op;
switch (i.getIntrinsicID()) {
case llvm::Intrinsic::is_fpclass: op = TestOp::Is_FPClass; break;
Expand All @@ -1135,6 +1157,7 @@ class llvm2alive_ : public llvm::InstVisitor<llvm2alive_, unique_ptr<Instr>> {
case llvm::Intrinsic::lifetime_end:
{
PARSE_UNOP();
addNoundefAssumes(i, {val});
if (isa<llvm::PoisonValue>(i.getOperand(1)))
return NOP(i);
if (i.getIntrinsicID() == llvm::Intrinsic::lifetime_end)
Expand Down Expand Up @@ -1166,6 +1189,7 @@ class llvm2alive_ : public llvm::InstVisitor<llvm2alive_, unique_ptr<Instr>> {
case llvm::Intrinsic::ptrmask:
{
PARSE_BINOP();
addNoundefAssumes(i, {a, b});
ret = make_unique<PtrMask>(*ty, value_name(i), *a, *b);
break;
}
Expand All @@ -1187,14 +1211,17 @@ class llvm2alive_ : public llvm::InstVisitor<llvm2alive_, unique_ptr<Instr>> {
}
case llvm::Intrinsic::vastart: {
PARSE_UNOP();
addNoundefAssumes(i, {val});
return make_unique<VaStart>(*val);
}
case llvm::Intrinsic::vaend: {
PARSE_UNOP();
addNoundefAssumes(i, {val});
return make_unique<VaEnd>(*val);
}
case llvm::Intrinsic::vacopy: {
PARSE_BINOP();
addNoundefAssumes(i, {a, b});
return make_unique<VaCopy>(*a, *b);
}

Expand All @@ -1216,6 +1243,7 @@ class llvm2alive_ : public llvm::InstVisitor<llvm2alive_, unique_ptr<Instr>> {
#undef PROCESS
{
PARSE_BINOP();
addNoundefAssumes(i, {a, b});
X86IntrinBinOp::Op op;
switch (i.getIntrinsicID()) {
#define PROCESS(NAME, A, B, C, D, E, F) \
Expand All @@ -1235,6 +1263,7 @@ class llvm2alive_ : public llvm::InstVisitor<llvm2alive_, unique_ptr<Instr>> {
#undef PROCESS
{
PARSE_TRIOP();
addNoundefAssumes(i, {a, b, c});
X86IntrinTerOp::Op op;
switch (i.getIntrinsicID()) {
#define PROCESS(NAME, A, B, C, D, E, F, G, H) \
Expand All @@ -1254,6 +1283,7 @@ class llvm2alive_ : public llvm::InstVisitor<llvm2alive_, unique_ptr<Instr>> {
#undef PROCESS
{
PARSE_QUADOP();
addNoundefAssumes(i, {a, b, c, d});
X86IntrinQuadOp::Op op;
switch (i.getIntrinsicID()) {
#define PROCESS(NAME) \
Expand Down
11 changes: 11 additions & 0 deletions tests/alive-tv/attrs/noundef-intrinsic-argument.srctgt.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
define float @src(float %a) {
%fabs = call float @llvm.fabs.f32(float noundef %a)
ret float %fabs
}

define noundef float @tgt(float %a) {
%fabs = call float @llvm.fabs.f32(float noundef %a)
ret float %fabs
}

declare float @llvm.fabs.f32(float)
Loading