Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy errors in openhands/llm directory #6812

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Conversation

neubig
Copy link
Contributor

@neubig neubig commented Feb 19, 2025

This PR fixes all mypy errors in the openhands/llm directory by:

  • Adding proper type annotations to functions
  • Fixing ModelInfo type issues
  • Fixing ModelResponse type issues
  • Fixing async iterator type issues
  • Adding proper return type annotations
  • Fixing decorator type issues

To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:5266187-nikolaik   --name openhands-app-5266187   docker.all-hands.dev/all-hands-ai/openhands:5266187

@neubig neubig self-assigned this Feb 21, 2025
@enyst enyst self-requested a review February 21, 2025 08:17
@neubig neubig marked this pull request as ready for review February 23, 2025 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants