fix: handle escaped quotes in PS1 metadata parsing #6827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add .replace(r'"', '"') to unescape quotes before parsing JSON in matches_ps1_metadata and from_ps1_match - Add test to verify PS1 metadata parsing works correctly - Fixes #6826
The issue was not with escaped quotes, but with backslashes in the JSON values being treated as literal backslashes. Fixed by properly escaping them with double backslashes. Fixes #6826
neubig
force-pushed
the
fix/6826-ps1-metadata-parsing
branch
2 times, most recently
from
7167eb5 to
56bac91
Compare
- Rename test to test_empty_command_ps1_metadata to reflect its purpose - Add test case with empty command to match the actual issue - Add better assertions for backslash handling - Add docstring explaining the test's purpose Part of #6826
neubig
force-pushed
the
fix/6826-ps1-metadata-parsing
branch
from
56bac91 to
8d95ce6
Compare
- Use raw strings for backslash sequences in PS1 metadata - Remove unnecessary quote escaping since json.dumps already handles it - Add tests to verify PS1 metadata parsing works correctly - Fixes #6826
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To run this PR locally, use the following command: