fix: handle PS1 metadata JSON escaping properly #6831
Draft
+41
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PS1 metadata JSON string was being doubly escaped, causing JSON parsing
to fail. This was happening because we were escaping quotes with
json_str.replace('"', r'"') after json.dumps() had already properly
escaped them.
This fix:
1. Removes the unnecessary quote escaping since json.dumps() already handles that
2. Adds a test to prevent the double-escaping issue from recurring
The JSON string in PS1 metadata doesn't need quote escaping because: 1. json.dumps() already produces valid JSON with properly escaped quotes 2. The JSON string is inside single quotes in PS1, so bash won't interpret backslashes This fixes the double-escaping issue that was causing JSON parsing to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6826
Fix double-escaping in PS1 metadata JSON and add test.
To run this PR locally, use the following command: