Keep the first user message by default in condensers #6888
+57
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces
Give a summary of what the PR does, explaining any non-trivial design decisions
This PR proposes to set the default
keep_first
to 1 everywhere in condensers, in a best effort attempt to preserve the first user message. We already did this in one of the condensers, this does it in all.The limit is configurable and accepts 0, but the use cases for 0 seem maybe eval cases or specific cases, while the first user message is important also because currently, we hook prompt extensions into it.
Link of any specific issues this addresses
To run this PR locally, use the following command: