Fix 43 Count Array Element performance test #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the K value from 501010 to 51010 so that it's in the input range of 1 to 100,000. Right now the answer to the performance test is always 0 since K is never in the input. Note that K is still extremely sparse in the input, so that naive solutions are still likely to outperform a standard reduction.
nikhila01
requested review from
ishaan-arya and
kunal-mansukhani
as code owners
Author
|
I forgot to add that submissions may need to be re-run after merging. Although as I said above, it probably won't affect solutions too much since K is still extremely sparse in the input, and non-reduction based solutions are still likely to perform best. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the K value from 501010 to 51010 so that it's in the input range of 1 to 100,000. Right now the answer to the performance test is always 0 since K is never in the input.
Note that K is still extremely sparse in the input, so that naive solutions are still likely to outperform a standard reduction. Since this is an Easy problem maybe that's ok. If not, a better performance test is needed.