fix handling of gamma encoding #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. not tested on web and android.
…the target buffer should be srgb, so writing without encoding will result in sth that is decoded 1 time too often. the symbols look a bit wrong (probably their texture needs the srgba format).
…l you need an extension, which i didn't test). so imo the better option is to manually encode after we are done. in theory we could do better by manually encoding in the g-buffer. however, the difference is hardly perceptible (i saw sth in the decoration buffer with the labels), and we risk other problems (sb. forgets it, bad filtering or blending).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.