included support for displaying the graph in 'klay' format (https://g… #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlrasheedA Can you please review this PR? |
|
Thanks for the PR! I’ve published a pre-release to PyPI with the Klay layout so you can install and use it: pip install st-link-analysis==0.5.0.dev1That said, I’m holding off on merging this into the main release line for now. Adding more layouts pushed the vendor bundle size beyond 700 KB. Before including additional extensions, I’d like to explore ways to improve how the bundling is handled. Once I’ve had a chance to revisit that, I’ll be in a better position to integrate JS extensions like this more broadly. Thanks again for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include support for displaying graph in 'klay' format (https://github.com/cytoscape/cytoscape.js-klay)