-
Notifications
You must be signed in to change notification settings - Fork 7
25.8 Antalya: Fix joins with Iceberg tables #1082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: antalya-25.8
Are you sure you want to change the base?
25.8 Antalya: Fix joins with Iceberg tables #1082
Conversation
|
Failed tests:
|
src/Storages/IStorageCluster.cpp
Outdated
| if (query_node.hasWhere() || query_node.hasPrewhere()) | ||
| { | ||
| CollectUsedColumnsForSourceVisitor collector_where(table_function_node, context, true); | ||
| if (query_node.hasPrewhere()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's quite odd that the original code didn't take prewhere into account...
If those are actually needed, we need to place a mental pin here that after backporting prewhere+row_policy we'll need to add hasRowLevelFilter here as well.
| assert node.query(f"SELECT * FROM {CATALOG_NAME}.`{root_namespace}.{table_encoded_name}`") == "\\N\tAAPL\t193.24\t193.31\t('bot')\n" | ||
|
|
||
|
|
||
| def test_cluster_joins(started_cluster): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test seems to be passing on the current Antalya branch:
test_database_iceberg/test.py::test_cluster_joins PASSED
Is it expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, test doesn't cover case with local right table, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And not on cluster...
…alya-25.8/s3cluster_global_join_fixes
fba187a to
39882f5
Compare
This reverts commit bff8bba.
|
Remove unused code |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix joins with Iceberg tables
Solved #1063 (I hope)
Documentation entry for user-facing changes
CI/CD Options
Exclude tests:
Regression jobs to run: