-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mutations after turning on zero-copy #690
base: customizations/24.8.14
Are you sure you want to change the base?
Fix mutations after turning on zero-copy #690
Conversation
This is an automated comment for commit 9cc18c2 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
59cc005
to
efee390
Compare
DROP TABLE IF EXISTS test03392_zero_copy_replication_r3; | ||
|
||
CREATE TABLE test03392_zero_copy_replication_r1 (x UInt64) | ||
ENGINE = ReplicatedMergeTree('/clickhouse/tables/test03392_zero_copy_replication','1') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ENGINE = ReplicatedMergeTree('/clickhouse/tables/test03392_zero_copy_replication','1') | |
ENGINE = ReplicatedMergeTree('/clickhouse/tables/{database}/test03392_zero_copy_replication','1') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests fixed
d92e365
to
599627e
Compare
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Turning zero-copy on existed table breaks mutations. This PR fixes it.
Documentation entry for user-facing changes