-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
24.8 leak scanning script #696
Conversation
sudo apt-get install -y dpkg-dev rpm2cpio cpio | ||
- name: Run leak check 1 | ||
run: | | ||
python3 scripts/scan_s3_artifacts.py altinity-build-artifacts ${{ env.PREFIX }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to add re to match ROBOT_TOKEN
from here: https://github.com/Altinity/ClickHouse/pull/693/files#diff-5399cabc63b54fc614af664aabf2e13ece95190dbc6b2442d1becc25d98c87faR14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It checks for leaks after the leak happened, IMO it would be more productive to scan files before uploading anything, and failing the job if there is a leak.
That way we are preventing the leak rather than detecting it (which would require us to mitigate the leak, which is quite elaborate) and also save enormous amount of time and traffic on pulling every single artifact back from S3 to the runner.
I suggest to modify S3Helper.upload_file
/S3Helper.upload_build_directory_to_s3
(maybe something else?)
https://github.com/Altinity/ClickHouse/blob/releases/24.8.14/tests/ci/s3_helper.py
Checking after is what was initially discussed. |
See #701 |
Changelog category (leave one):
Scan all files uploaded to S3 for
[A-Z_]*(SECRET|PASSWORD)[A-Z_]*