Fix information activity after purge

[Ceredron]

Description

It is not possible to set status on a dialog after it has been purged. Therefore the information activity reports must be performed synchronously.

This is the cause of our Slack spams.

Related Issue(s)

• Bug: Dialog blir forsøkt oppdatert etter sletting #848

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)
• All tests run green

Documentation

• User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Summary by CodeRabbit

• Refactor
  • Streamlined correspondence activity processing by eliminating intermediary steps to directly update notifications.
  • Improved internal handling of activity reporting to ensure more consistent and reliable performance.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes update the encapsulation of the PurgeCorrespondenceHelper class. The _dialogportenService field is now marked as private readonly, and the ReportActivityToDialogporten method has been refactored to directly call the service’s CreateInformationActivity method instead of enqueuing a background job. The parameters for the service call remain unchanged.

Changes

File	Change Summary
src/Altinn.Correspondence.Application/PurgeCorrespondence/PurgeCorrespondenceHelper.cs	Updated _dialogportenService to private readonly; refactored ReportActivityToDialogporten to call CreateInformationActivity directly.

Possibly related PRs

• delete dialog when publish goes wrong #682: Adjusts _dialogportenService usage and introduces interface changes that correlate with this PR’s modifications.
• Move purgeCorrespondence to helper #772: Consolidates functionality in the PurgeCorrespondenceHelper by directly handling the _dialogportenService field.
• LegacyController: PurgeCorrespondence #480: Modifies the purging process by altering the handling of _dialogportenService, which aligns closely with the changes in this PR.

Suggested labels

kind/enhancement

Suggested reviewers

• Andreass2

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2e0ad16 and 31e9e8b.

📒 Files selected for processing (1)

• src/Altinn.Correspondence.Application/PurgeCorrespondence/PurgeCorrespondenceHelper.cs (2 hunks)

🔇 Additional comments (2)

src/Altinn.Correspondence.Application/PurgeCorrespondence/PurgeCorrespondenceHelper.cs (2)

19-19: Improved field encapsulation.

Adding the private readonly modifiers to the _dialogportenService field improves encapsulation and ensures the reference cannot be modified after initialization. This is a good practice that aligns with proper dependency management in C#.

---

106-106: Update caller method to handle asynchronous reporting.

If you implement the suggested changes to make ReportActivityToDialogporten asynchronous, this line will need to be updated to await the result.

- ReportActivityToDialogporten(isSender: isSender, correspondence.Id);
+ await ReportActivityToDialogporten(isSender: isSender, correspondence.Id);

Verify the signature of CreateInformationActivity in the IDialogportenService interface to confirm whether it returns a Task that should be awaited.

[Andreass2]

looks good