Chore 1738 remove unused functions - #1818
Open
eskebab wants to merge 6 commits into
Open
Conversation
added 4 commits
August 11, 2026 14:56
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe migration versions notification functions, adds ChangesNotification SQL changes
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant cancelorder_v2
participant getorder_includestatus_v5
participant NotificationOrder
cancelorder_v2->>getorder_includestatus_v5: request order details
getorder_includestatus_v5->>NotificationOrder: read ResourceAction
NotificationOrder-->>getorder_includestatus_v5: return order status and resourceaction
getorder_includestatus_v5-->>cancelorder_v2: return order details
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
eskebab
marked this pull request as ready for review
August 12, 2026 12:15
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
components/api/src/Altinn.Notifications.Persistence/Migration/v0.95/01-drop-unused-functions.sql (1)
35-35: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winRemove the duplicate
updatesmsnotification_v2drop.Line 25 already drops
notifications.updatesmsnotification_v2(text, text, uuid). The secondDROP FUNCTION IF EXISTSis harmless, but it makes the migration harder to audit and may hide a missing cleanup entry.Proposed fix
- DROP FUNCTION IF EXISTS notifications.updatesmsnotification_v2(text, text, uuid); -- v2🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@components/api/src/Altinn.Notifications.Persistence/Migration/v0.95/01-drop-unused-functions.sql` at line 35, Remove the duplicate DROP FUNCTION statement for notifications.updatesmsnotification_v2(text, text, uuid) from the migration, keeping the existing earlier drop entry unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@components/api/src/Altinn.Notifications.Persistence/Migration/v0.95/01-drop-unused-functions.sql`:
- Line 35: Remove the duplicate DROP FUNCTION statement for
notifications.updatesmsnotification_v2(text, text, uuid) from the migration,
keeping the existing earlier drop entry unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 66addb48-a1ff-4537-9669-9e1fdb7972fa
📒 Files selected for processing (1)
components/api/src/Altinn.Notifications.Persistence/Migration/v0.95/01-drop-unused-functions.sql
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Verification
Documentation
Summary by CodeRabbit
New Features
Improvements