chore: studio should only us appid parameter for queries#968
chore: studio should only us appid parameter for queries#968martinothamar wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe StudioInstanceParameters.ToInstanceQueryParameters() object initializer no longer assigns the Org field to the returned InstanceQueryParameters; AppId remains set as "{Org}/{App}" and all other mappings are unchanged. ChangesInstance Query Parameter Mapping
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c41c065 to
b3b9595
Compare
b3b9595 to
e1897b5
Compare
|



Description
If I understood correctly, using both of these as predicates leads to worse perf,
Orgis redundant when we already haveAppIdRelated Issue(s)
Verification
Documentation
Summary by CodeRabbit