Skip to content

chore: studio should only us appid parameter for queries#968

Open
martinothamar wants to merge 1 commit into
mainfrom
chore/studio-instance-parameters-only-appid
Open

chore: studio should only us appid parameter for queries#968
martinothamar wants to merge 1 commit into
mainfrom
chore/studio-instance-parameters-only-appid

Conversation

@martinothamar

@martinothamar martinothamar commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Description

If I understood correctly, using both of these as predicates leads to worse perf, Org is redundant when we already have AppId

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Summary by CodeRabbit

  • Bug Fixes
    • Fixed handling of studio instance parameters so an incorrect organization value is no longer applied.
    • Preserved the combined app identifier format to ensure existing routing and lookups continue to work.
    • Prevents potential misrouting or parameter conflicts caused by the previous assignment.

Review Change Stack

@coderabbitai

coderabbitai Bot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fc8f21dd-ca7f-4930-b845-00304d261f3d

📥 Commits

Reviewing files that changed from the base of the PR and between b3b9595 and e1897b5.

📒 Files selected for processing (1)
  • src/Storage/Models/StudioInstanceParameters.cs
💤 Files with no reviewable changes (1)
  • src/Storage/Models/StudioInstanceParameters.cs

📝 Walkthrough

Walkthrough

The StudioInstanceParameters.ToInstanceQueryParameters() object initializer no longer assigns the Org field to the returned InstanceQueryParameters; AppId remains set as "{Org}/{App}" and all other mappings are unchanged.

Changes

Instance Query Parameter Mapping

Layer / File(s) Summary
Remove Org assignment
src/Storage/Models/StudioInstanceParameters.cs
Omit Org from the InstanceQueryParameters object initializer in ToInstanceQueryParameters(); AppId continues to be set to "{Org}/{App}" and other properties are preserved.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title contains a typo ('us' instead of 'use') and is somewhat vague, but it clearly indicates the main change: removing the Org parameter from queries.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/studio-instance-parameters-only-appid

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Konrad-Simso Konrad-Simso force-pushed the chore/studio-instance-parameters-only-appid branch from c41c065 to b3b9595 Compare May 20, 2026 06:19
@Konrad-Simso Konrad-Simso force-pushed the chore/studio-instance-parameters-only-appid branch from b3b9595 to e1897b5 Compare May 26, 2026 10:29
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants