[WIP] Signering #2871
Draft
[WIP] Signering #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP * adds zod * adds start of signee list component * makes app table type generic * renders tag in table for signee status * adds header styling to signee list table * adds todos and some error handling * removes fake prop in schema to trigger parsing error * moves signee state tag component to its own file * adds language and error message when process task is not a signing task * fixes caption helptext display * added support for caption, description and helptext and sized table to md * adds support for organisation signature * adds lang texts for table header * adds sorting on name column * updates todos and removes unnecessary accessors * right aligns the last column * updates TODOs * removes not found and unnecessary caption font-size * smaller improvement to error handling * adds custom error message to refine * simplifies error handling * fixes css classes * adds support for is loading status in table and signee table * extracts signee list error component to its own file * fixes codeql warning and adds test for getSigneeStatus * moves data fetching function and related code out of component file * adds api tests * adds stale time and simplifies signee list query object * fixes moved import * fixes org lookup css classes * adds signee list component unit tests * code review cleanup
* add datamodelbinding for surname for personlookup * rm surname datamodelbinding and compose fullname * update validation of person lookup name * rm surname from datamodelbindings * validate first and last name * validate tempName inline * Update src/layout/PersonLookup/PersonLookupComponent.tsx Co-authored-by: Camilla Marie Dalan <[email protected]> --------- Co-authored-by: Camilla Marie Dalan <[email protected]>
|
/publish |
Published PR packages:
|
* WIP signing document list * adds support for selflinks apps blob url * adds support for attachment type in table * moves error component to own file * supports loading in signing doc list table * adds error message when component is used in a non signing task * fixes cypress test * fixes import error * moves api stuff out to api file * adds tests for signing document list component * code review fixes
|
/publish |
Published PR packages:
|
…if no set filename (#2910)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
* Signing panel scaffolding * fixes tests * updates eslint rules for test files * fixes function name casing * makes panel full width by default and moves full width and conditional wrappers to app-components * implements functions and cleans up code * removes reject button in mvp * renames waiting status in current user status * replaces signee list staleTime with refetchInterval and added padding to signing panel * adds deprecated warning to getDataValidationUrl * uses css classes instead of inline css * adds text resource defaults * fixes spacing in panel and alignment of checkbox and label * adds checkbox label and description config to layout component * fixes signing document list component test * adds all text resources as props for override capability * renames go_to_inbox -> no_action_required * adds reject button to panel if user has reject rights * adds text resource binding props and text resource defaults for reject signing process modal * ignore layout config.ts files for sonarcloud * renames SubmitPanel -> PanelSubmit renames SigningPanel -> PanelSigning, NoActionRequiredPanel -> PanelNoActionRequired and AwaitingCurrentUserSignaturePanel -> PanelAwaitingCurrentUserSignature * splits submit panel in awaiting other signatures panel and submit panel with corresponding text resource changes * returns no action required panel * fixes inverted logic error * QA fixes * removes redundant tests * fixes document list test
|
/publish |
Published PR packages:
|
|
/publish |
PR release:
|
|
/publish |
PR release:
|
* adds signee list summary override for title * fixes and adds new tests
|
/publish |
PR release:
|
|
/publish |
PR release:
|
HauklandJ
added
the
backport-ignore
* deletes unused hook * improves PartySelection error message * gets instance owner party from backend and correctly determines on behalf of in app header * fixes eslint warning * adds enabled prop to instance owner query, and improves useInstanceOwner logic and readablility * gets instance owner party from new data on instance from backend with fallback to finding it in parties * removes cookie utils * add expression support for organisation instance owner name * update tests * add shared-tests * expose instace owner name always * fixes flattening parties and checking if same party by partyId in app header * fixes sonarqube maintainability complaint * fixes another sonarqube maintainability complaint * removes unused query key * gets instance owner name straight from cache instead of zustand which might have been overwritten * gets instance owner data from cache instead of performing another query --------- Co-authored-by: Camilla Marie Dalan <[email protected]>
* scaffolding, commented out code, and generally chaos * update yarn lock * add onBehalfOf to doPerformAction query * update schema * update the org check logic * update the change handle on the radio group to set the orgnr for the value * add text resources for signing panel radio group * rm commented out code * use fieldset instead of radio group * pr feedback * different views for different on behalf of * make header smaller for single choice org on behalf of
* move onhebalfofchooser, make state nullable * set on behlaf of for single choice
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Verification/QA
kind/*label to this PR for proper release notes grouping