Chore/update ds #3231
Chore/update ds #3231
Conversation
|
/publish |
PR release:
|
| onChange, | ||
| ...rest | ||
| }: PaginationComponentProps) { | ||
| const { pages, showNextPage, showPreviousPage } = usePagination({ | ||
| compact, | ||
| const { pages, prevButtonProps, nextButtonProps, hasPrev, hasNext } = usePagination({ |
There was a problem hiding this comment.
Github is complaining that compact is defined but never used in this component now. 🤔
| test: /\.tsx?$/, | ||
| loader: 'esbuild-loader', | ||
| options: { | ||
| target: 'es2020', |
There was a problem hiding this comment.
Ooh, this is a good point - yet another reason we might want extensive testing for this one. According to this comment, ES2020 (aka ES11) is more than fine, but this might of course break older stuff.
There was a problem hiding this comment.
Forgot the link, but here it is: https://digdir.slack.com/archives/C07A822E9PT/p1749541859505669?thread_ts=1747917879.904519&cid=C07A822E9PT
|
We should also take a look at all the issues linked to #2600 that we might want to close as solved after this. 🤔 I saw at least one thing I remember being and issue which you seem to have fixed here (I didn't test, just read the code). |
|
Description
Related Issue(s)
Verification/QA
Manual functionality testing
Automated tests
UU/WCAG (follow these guidelines until we have our own)
User documentation @ altinn-studio-docs
Support in Altinn Studio
Sprint board
Labels
kind/*andbackport*label to this PR for proper release notes grouping