Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add expression support for organisation instance owner name #3232

Merged
merged 21 commits into from
Apr 8, 2025

Conversation

HauklandJ
Copy link
Contributor

@HauklandJ HauklandJ commented Apr 3, 2025

Description

Related Issue(s)

  • closes #{issue number}

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@HauklandJ HauklandJ added backport-ignore This PR is a new feature and should not be cherry-picked onto release branches kind/feature-request New feature or request kind/product-feature Pull requests containing new features and removed kind/feature-request New feature or request labels Apr 3, 2025
@ivarne
Copy link
Member

ivarne commented Apr 3, 2025

A (few) shared test(s) https://github.com/Altinn/app-frontend-react/tree/main/src/features/expressions/shared-tests/functions/instanceContext would be nice :)

@HauklandJ HauklandJ requested a review from ivarne April 4, 2025 07:47
@HauklandJ HauklandJ enabled auto-merge (squash) April 4, 2025 07:54
@HauklandJ HauklandJ requested a review from bjosttveit April 4, 2025 13:13
@cammiida cammiida added this to the Signering MVP milestone Apr 7, 2025
@cammiida cammiida changed the base branch from main to fix/current-party-2 April 7, 2025 18:12
auto-merge was automatically disabled April 7, 2025 18:12

Head branch was modified

Base automatically changed from fix/current-party-2 to main April 8, 2025 07:40
Copy link

sonarqubecloud bot commented Apr 8, 2025

@HauklandJ HauklandJ changed the base branch from main to feature/signing April 8, 2025 10:27
@HauklandJ HauklandJ merged commit 589659e into feature/signing Apr 8, 2025
15 checks passed
@HauklandJ HauklandJ deleted the feature/instanceOwnerName branch April 8, 2025 10:27
Copy link
Contributor

@olemartinorg olemartinorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🙌 This will also affect text resource variables, so the docs for that should be updated: https://docs.altinn.studio/nb/altinn-studio/reference/ux/texts/#datakilder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-ignore This PR is a new feature and should not be cherry-picked onto release branches kind/product-feature Pull requests containing new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants