-
Notifications
You must be signed in to change notification settings - Fork 32
Fixing missing instantiation error(s) #3259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
olemartinorg
wants to merge
9
commits into
main
Choose a base branch
from
bug/instantiation-error
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
test/e2e/pageobjects/party-mocks.ts:164
- Using the logical OR (||) here forces a falsy activeInstances value (specifically false) to default to an empty array, which may not be the intended behavior. Consider checking explicitly for a false value to ensure clarity in the mock behavior.
cy.intercept('**/active', whatToMock.activeInstances || []).as('activeInstances');
cammiida
reviewed
Apr 9, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the missing instantiation error that didn't appear when creating a new instance from the instance selection screen.
I added a route for this error, and read the exception to print out the actual error. This also means that you can navigate to that route and just end up with a generic/unknown error.The error is now displayed inside anErrorReport
around the button.It also fixes the same when instantiating via a
InstantiationButton
from a stateless app. I wanted to rework this even more for stateless apps, as you might want to use aIInstantiationValidator
to disallow some prefill values when creating a new instance with prefill (i.e. using theInstantiationButton
withmapping
). However, it doesn't seem like that's possible yet in the backend.If we get a feature request for that, we'd probably have to change both the backend and frontend at that point instead. Optimally the error should be displayed inline as a validation error in the stateless form, such that the user can make changes in the stateless form and retry - but right now I can't find a clear way for a change in the stateless form to make a difference in theIInstantiationValidator
, so I'm scrapping that idea.Update: We've been discussing alternative solutions here: https://digdir.slack.com/archives/C085N9FPDFS/p1744199886413489
Related Issue(s)
InstanceSelection
doesn't render error messages #2578Verification/QA
kind/*
andbackport*
label to this PR for proper release notes grouping