Skip to content

Refetch instance data on task change by adding task id to query key #3263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cammiida
Copy link
Contributor

@cammiida cammiida commented Apr 10, 2025

Description

Instance data is not necessarily updated on task change. Added task id to query key to make sure it is being refetched.

Related Issue(s)

  • closes #{issue number}

Verification/QA

  • Manual functionality testing

    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests

    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)

    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs

    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio

    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board

    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels

    • I have added a kind/* and backport* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@cammiida cammiida added backport-ignore This PR is a new feature and should not be cherry-picked onto release branches kind/bug Something isn't working backport This PR should be cherry-picked onto older release branches and removed backport-ignore This PR is a new feature and should not be cherry-picked onto release branches labels Apr 10, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
33.3% Coverage on New Code (required ≥ 45%)
0.0% Condition Coverage on New Code (required ≥ 45%)

See analysis details on SonarQube Cloud

@cammiida cammiida marked this pull request as draft April 10, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport This PR should be cherry-picked onto older release branches kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant