Skip to content

Signing/mob review fixes 1 #3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 25, 2025
Merged

Conversation

cammiida
Copy link
Contributor

@cammiida cammiida commented Apr 25, 2025

Description

  • Fixes signing flow for choosing party
  • Smaller fixes to improve code readability and structure
  • Fixes tests
  • Renames summary_title -> summaryTitle and removes Summary2 override
  • Shows error message when submit button is clicked and there are missing signatures instead of having it disabled

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* and backport* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@cammiida cammiida self-assigned this Apr 25, 2025
@cammiida cammiida added kind/other Pull requests containing chores/repo structure/other changes backport-ignore This PR is a new feature and should not be cherry-picked onto release branches labels Apr 25, 2025
@cammiida cammiida moved this to 🔎 Review in Team Apps Apr 25, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes the signing flow for choosing party, updates UI text resources, and improves code structure and test stability. Key changes include introducing a new state (userTriedToSubmit) to handle error messaging on submission, refactoring hooks to use updated query hooks (useDocumentList and useSigneeList), and renaming text resource keys from summary_title to summaryTitle.

Reviewed Changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/layout/SigningStatusPanel/PanelAwaitingOtherSignatures.tsx Adds userTriedToSubmit state and an effect to reset errors after 10 seconds; changes the submit button behavior.
src/layout/SigningStatusPanel/PanelAwaitingCurrentUserSignature.tsx Refactors and renames state variables for organization selection and updates mutation handling.
src/layout/SigningDocumentList/* Migrates from fetchDocumentList to a useDocumentList hook and adjusts sorting of documents.
src/layout/SigneeList/* Switches from useQuery to useSigneeList, updates text resource key naming, and refines the summary rendering and tests.
src/language/texts/* Updates language texts to reflect renaming and improved error messages.
Comments suppressed due to low confidence (1)

src/layout/SigningDocumentList/api.ts:45

  • Usage of Array.prototype.toSorted is a recent addition to JavaScript. Ensure that the target runtime environment supports this method or include a polyfill if needed.
.toSorted((a, b) => (a.filename ?? '').localeCompare(b.filename ?? ''));

@cammiida cammiida force-pushed the signing/mob-review-fixes-1 branch from 0ecb824 to d96a5d0 Compare April 25, 2025 10:16
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
28.6% Coverage on New Code (required ≥ 45%)
C Reliability Rating on New Code (required ≥ A)
6.9% Condition Coverage on New Code (required ≥ 45%)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Contributor

@HauklandJ HauklandJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@cammiida cammiida merged commit 703d9a9 into feature/signing Apr 25, 2025
13 of 15 checks passed
@cammiida cammiida deleted the signing/mob-review-fixes-1 branch April 25, 2025 12:30
@github-project-automation github-project-automation bot moved this from 🔎 Review to 🧪 Test in Team Apps Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-ignore This PR is a new feature and should not be cherry-picked onto release branches kind/other Pull requests containing chores/repo structure/other changes
Projects
Status: 🧪 Test
Development

Successfully merging this pull request may close these issues.

2 participants