-
Notifications
You must be signed in to change notification settings - Fork 32
Signing/mob review fixes 1 #3318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request fixes the signing flow for choosing party, updates UI text resources, and improves code structure and test stability. Key changes include introducing a new state (userTriedToSubmit) to handle error messaging on submission, refactoring hooks to use updated query hooks (useDocumentList and useSigneeList), and renaming text resource keys from summary_title to summaryTitle.
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/layout/SigningStatusPanel/PanelAwaitingOtherSignatures.tsx | Adds userTriedToSubmit state and an effect to reset errors after 10 seconds; changes the submit button behavior. |
src/layout/SigningStatusPanel/PanelAwaitingCurrentUserSignature.tsx | Refactors and renames state variables for organization selection and updates mutation handling. |
src/layout/SigningDocumentList/* | Migrates from fetchDocumentList to a useDocumentList hook and adjusts sorting of documents. |
src/layout/SigneeList/* | Switches from useQuery to useSigneeList, updates text resource key naming, and refines the summary rendering and tests. |
src/language/texts/* | Updates language texts to reflect renaming and improved error messages. |
Comments suppressed due to low confidence (1)
src/layout/SigningDocumentList/api.ts:45
- Usage of Array.prototype.toSorted is a recent addition to JavaScript. Ensure that the target runtime environment supports this method or include a polyfill if needed.
.toSorted((a, b) => (a.filename ?? '').localeCompare(b.filename ?? ''));
…clicked and there are missing signatures
0ecb824
to
d96a5d0
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
Description
summary_title
->summaryTitle
and removesSummary2
overrideRelated Issue(s)
Verification/QA
kind/*
andbackport*
label to this PR for proper release notes grouping