pretrained.py: Fix undefined name fatal #1938
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The import of `fatal` was commented out at 4eb3a96 * https://docs.python.org/3/library/exceptions.html#NotADirectoryError This was the only direct usage of `dora`, so that dependency can probably be removed from `requirements.txt`. Also removed the duplicate `import logging`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The import of
fatalwas commented out at 4eb3a96, so let's raise aNotADirectoryErrorinstead.This was the only direct usage of
Dora, so that dependency can probably be removed fromrequirements.txt.ultimatevocalremovergui/requirements.txt
Line 41 in 5517e0c
Also removed the duplicate
import loggingwhich was already done on line 9.