feat: add IoT provider support and related credentials definitions #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SagiROosto
force-pushed
the
add-aws-iot-credentials
branch
2 times, most recently
from
dccc981 to
cfb2313
Compare
yuvalDOosto
requested changes
Aug 17, 2025
yuvalDOosto
left a comment
yuvalDOosto
left a comment
There was a problem hiding this comment.
Good job, added some comments, I have to look at it again due to flb_aws_credential_iot.c length but the current comments are a good start
SagiROosto
force-pushed
the
add-aws-iot-credentials
branch
from
7d5c82f to
a44c9ab
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces AWS IoT credentials provider support to Fluent Bit, enabling authentication using IoT device certificates. The implementation adds a new credentials provider that uses IoT-specific environment variables and TLS certificate authentication to obtain temporary AWS credentials from an IoT credentials endpoint.
Key changes:
- Added complete IoT credentials provider implementation with TLS certificate support
- Integrated IoT provider into the standard AWS credentials chain
- Added environment variable definitions for IoT configuration parameters
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/aws/flb_aws_credentials_iot.c | New IoT credentials provider implementation with certificate-based authentication |
| src/aws/flb_aws_credentials.c | Integration of IoT provider into standard credentials chain |
| src/aws/CMakeLists.txt | Added new IoT credentials source file to build |
| include/fluent-bit/flb_aws_credentials.h | Added IoT environment variable definitions and function declaration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
SagiROosto
force-pushed
the
add-aws-iot-credentials
branch
from
980eb2e to
12cfd40
Compare
yuvalDOosto
reviewed
Oct 23, 2025
yuvalDOosto
reviewed
Oct 23, 2025
yuvalDOosto
approved these changes
Oct 23, 2025
Author
|
since the PR to original repo is from the master branch and still in progress, we'll wait for it to be merged first fluent#10824 |
SagiROosto
force-pushed
the
master
branch
2 times, most recently
from
c6119a3 to
7d400e8
Compare
SagiROosto
force-pushed
the
add-aws-iot-credentials
branch
2 times, most recently
from
e73bf6f to
1dd803d
Compare
SagiROosto
force-pushed
the
add-aws-iot-credentials
branch
from
1dd803d to
5168712
Compare
SagiROosto
force-pushed
the
add-aws-iot-credentials
branch
from
5168712 to
d4bbef3
Compare
* add logrotate out plugin * fix gzip * fix test * update max_size * update gzip * add logs Signed-off-by: SagiROosto <[email protected]>
Signed-off-by: SagiROosto <[email protected]>
Signed-off-by: SagiROosto <[email protected]>
Signed-off-by: SagiROosto <[email protected]>
Signed-off-by: SagiROosto <[email protected]>
Signed-off-by: SagiROosto <[email protected]>
Signed-off-by: SagiROosto <[email protected]>
…d fix UT Signed-off-by: SagiROosto <[email protected]>
…ad of hash table This change replaces the hash table with a linked list for storing file sizes, improving memory management and simplifying the code. Additionally, helper functions for managing file size entries have been added, enhancing the overall structure and readability of the logrotate plugin. Signed-off-by: SagiROosto <[email protected]>
Signed-off-by: SagiROosto <[email protected]>
…ng support This commit introduces several new test functions for various log formats including CSV, LTSV, plain text, MsgPack, and template formats. Additionally, it enhances the multithreading capabilities of the logrotate tests, ensuring that data is correctly handled and written in a concurrent environment. The changes also include helper functions for reading file content and verifying the output format. Signed-off-by: SagiROosto <[email protected]>
Signed-off-by: SagiROosto <[email protected]>
Signed-off-by: SagiROosto <[email protected]>
Signed-off-by: SagiROosto <[email protected]>
…and improve directory creation and rotation logic. Signed-off-by: SagiROosto <[email protected]>
… MSVC builds. Signed-off-by: SagiROosto <[email protected]>
…ssion Signed-off-by: SagiROosto <[email protected]>
Signed-off-by: SagiROosto <[email protected]>
Signed-off-by: SagiROosto <[email protected]>
…initions This update introduces the IoT provider creation function and adds necessary environment variable definitions for IoT credentials in the AWS module. Additionally, the CMake configuration is updated to include the new IoT credentials source file. Signed-off-by: Eduardo Silva <[email protected]> Signed-off-by: SagiROosto <[email protected]>
Signed-off-by: SagiROosto <[email protected]>
Signed-off-by: SagiROosto <[email protected]>
Signed-off-by: SagiROosto <[email protected]>
SagiROosto
force-pushed
the
add-aws-iot-credentials
branch
from
d4bbef3 to
9761fcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update introduces the IoT provider creation function and adds necessary environment variable definitions for IoT credentials in the AWS module. Additionally, the CMake configuration is updated to include the new IoT credentials source file.