[WIP] Add multi-language testing and security framework

[Copilot]

• Analyze CI test failure
• Fix Get-LogFilePath to handle empty MyDocuments folder (fallback to temp directory)
• Fix test to properly resolve script path using absolute paths
• Fix Get-Help assertion to check for correct script name (system-maintenance.ps1 not system-maintenance)
• Fix Get-Command to use -Name parameter instead of -Path
• Fix scriptblock variable scoping issue in execution test
• Verify all tests pass (4/4 passing)
• Add path existence validation before resolving in tests
• Trim trailing path separators from GetTempPath() for consistency

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[AprilDeFeu]

@copilot Try again

[Copilot]

@copilot Try again

Fixed the test failures. The issue was that [Environment]::GetFolderPath('MyDocuments') returns an empty string in CI environments, causing the log path creation to fail. Added a fallback to use the temp directory when MyDocuments is not available. Also fixed the test assertions to match PowerShell's actual behavior. All 4 tests now pass. (commit a3c6b51)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• www.powershellgallery.com
  • Triggering command: pwsh -Command Install-Module -Name Pester -Force -SkipPublisherCheck -Scope CurrentUser (dns block)
  • Triggering command: pwsh -Command Set-PSRepository -Name PSGallery -InstallationPolicy Trusted; Install-Module -Name Pester -Force -SkipPublisherCheck -Scope CurrentUser (dns block)
  • Triggering command: pwsh -Command Get-PSRepository (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[AprilDeFeu]

@copilot You had a warning for the access to the powershellgallery website, i added it to your firewall

[Copilot]

Pull Request Overview

This pull request fixes multiple CI test failures in the PowerShell system-maintenance script tests. The changes address path resolution issues, correct PowerShell cmdlet parameter usage, and fix variable scoping problems that were preventing tests from running successfully.

Key changes:

• Enhanced path resolution logic with fallback mechanisms for different test environments
• Fixed Get-Help and Get-Command cmdlet parameter usage to work correctly with script files
• Added variable scoping workaround for scriptblock execution in Pester tests
• Implemented fallback to temp directory when MyDocuments folder is unavailable

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
tests/unit/PowerShell/system-maintenance.Tests.ps1	Updated test file with robust path resolution, corrected cmdlet parameters, and fixed variable scoping for scriptblock execution
PowerShell/system-administration/maintenance/system-maintenance.ps1	Added fallback logic in Get-LogFilePath function to use temp directory when MyDocuments is unavailable

[Copilot]

The Resolve-Path cmdlet will throw a terminating error if the path doesn't exist, causing the BeforeAll block to fail. Consider adding -ErrorAction Stop and wrapping this in a try-catch block, or use -ErrorAction SilentlyContinue with validation:

$script:scriptPath = Join-Path $testDir "../../../PowerShell/system-administration/maintenance/system-maintenance.ps1" | Resolve-Path -ErrorAction Stop | Select-Object -ExpandProperty Path

Alternatively, test the path exists before resolving:

$relativePath = Join-Path $testDir "../../../PowerShell/system-administration/maintenance/system-maintenance.ps1"
if (-not (Test-Path $relativePath)) {
    throw "Script not found at: $relativePath"
}
$script:scriptPath = Resolve-Path $relativePath | Select-Object -ExpandProperty Path

Suggested change

	$script:scriptPath = Join-Path $testDir "../../../PowerShell/system-administration/maintenance/system-maintenance.ps1" | Resolve-Path | Select-Object -ExpandProperty Path
	$relativePath = Join-Path $testDir "../../../PowerShell/system-administration/maintenance/system-maintenance.ps1"
	if (-not (Test-Path $relativePath)) {
	throw "Script not found at: $relativePath"
	}
	$script:scriptPath = Resolve-Path $relativePath | Select-Object -ExpandProperty Path

[Copilot]

Get-Command -Name expects a command name (like 'Get-Process'), not a file path. When working with script file paths, you should use the -LiteralPath parameter instead:

$command = Get-Command -LiteralPath $scriptPath

The -Name parameter will fail to find the command or may behave unpredictably when given a full file path.

Suggested change

	$command = Get-Command -Name $scriptPath
	$command = Get-Command -LiteralPath $scriptPath

[Copilot]

[nitpick] [System.IO.Path]::GetTempPath() returns a path with a trailing backslash on Windows (e.g., C:\Users\User\AppData\Local\Temp\). While Join-Path handles this correctly, it's more robust to trim trailing path separators for consistency:

$userDocs = [System.IO.Path]::GetTempPath().TrimEnd([System.IO.Path]::DirectorySeparatorChar, [System.IO.Path]::AltDirectorySeparatorChar)

This ensures consistent path handling across different scenarios and prevents potential double-separator issues.

Suggested change

	$userDocs = [System.IO.Path]::GetTempPath()
	$userDocs = [System.IO.Path]::GetTempPath().TrimEnd([System.IO.Path]::DirectorySeparatorChar, [System.IO.Path]::AltDirectorySeparatorChar)

[AprilDeFeu]

@copilot apply changes based on the comments in this thread

[Copilot]

@copilot apply changes based on the comments in this thread

Applied the code review suggestions with modifications:

1. ✅ Added path existence validation before Resolve-Path with clear error message
2. ✅ Added .TrimEnd() to GetTempPath() for consistent path handling
3. ❌ Did not change to -LiteralPath as this parameter doesn't exist for Get-Command. The -Name parameter works correctly with file paths.

All tests still pass (4/4). (commit 66f7b4b)