Skip to content

Webviewer wpf #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Webviewer wpf #45

wants to merge 3 commits into from

Conversation

DavidEGutierrez
Copy link
Collaborator

Description

Resources

Checklist

  • I understand that this is a public repo and my changes will be publicly visible

If you are adding a new sample

  • I have added an entry to the root level README
  • The name of my sample is consistent with the other samples
  • I have added a README to my sample
  • The sample is fully functional
  • I have updated lerna.json with the new sample name

If you are removing an old sample

  • I have removed the entry from the root level README
  • I have removed the sample from lerna.json

Created sample that implements the WebViewer in WPF using WebView2. The sample creates a virtual host for the WebView2 to make use of the local files.
1. Added entry to lerna.json.
2. Added entry in root level README
Spacing correction

const copyFiles = async () => {
try {
await fs.copy('./node_modules/@pdftron/webviewer/public', './webview2/webviewer/lib');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to /lib/webviewer? Just to be consistent with all our other samples

<script>
WebViewer.Iframe({
path: 'lib', // path to the Apryse 'lib' folder on your server
initialDoc: 'WebviewerDemoDoc.pdf',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change this to https://apryse.s3.amazonaws.com/public/files/samples/WebviewerDemoDoc.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants