Conversation
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| CodeStyle | 1 minor |
TIP This summary will be updated as you push new changes. Give us feedback
There was a problem hiding this comment.
Code Review
This pull request extends date handling support by adding java.time.OffsetDateTime to DateUtils and implementing a specialized dateComparator in GremlinValueComparator to handle mixed date types with nanosecond precision. Additionally, the type resolution logic in GremlinValueComparator was refactored for better performance. Feedback was provided regarding a potential overflow issue in DateUtils when calculating nanosecond timestamps for dates far in the future, as well as a warning that the new dateComparator may yield incorrect results for LocalDate types due to existing precision bugs in the underlying utility methods.
What does this PR do?
fix failing Gremlin test
Checklist
mvn clean packagecommand