Skip to content

fix GremlinValueComparator#3870

Merged
robfrank merged 2 commits intomainfrom
fix/gremlin-failing-test
Apr 16, 2026
Merged

fix GremlinValueComparator#3870
robfrank merged 2 commits intomainfrom
fix/gremlin-failing-test

Conversation

@robfrank
Copy link
Copy Markdown
Collaborator

What does this PR do?

fix failing Gremlin test

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@robfrank robfrank added this to the 26.4.1 milestone Apr 16, 2026
@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Apr 16, 2026

Not up to standards ⛔

🔴 Issues 1 minor

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results
CodeStyle 1 minor

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request extends date handling support by adding java.time.OffsetDateTime to DateUtils and implementing a specialized dateComparator in GremlinValueComparator to handle mixed date types with nanosecond precision. Additionally, the type resolution logic in GremlinValueComparator was refactored for better performance. Feedback was provided regarding a potential overflow issue in DateUtils when calculating nanosecond timestamps for dates far in the future, as well as a warning that the new dateComparator may yield incorrect results for LocalDate types due to existing precision bugs in the underlying utility methods.

Comment thread engine/src/main/java/com/arcadedb/utility/DateUtils.java Outdated
@robfrank robfrank merged commit c9590ef into main Apr 16, 2026
19 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant